-
Notifications
You must be signed in to change notification settings - Fork 739
Convert CommonVoice tartar training file from mp3 to wav (8kHz), and remove unused file #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert CommonVoice tartar training file from mp3 to wav (8kHz), and remove unused file #772
Conversation
Used 'sox -i <mp3> <wav>' with default 14.4.2 options
Issue also mentioned test.wav accidentally checked in but this does not seem to be there.
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 32 32
Lines 2617 2617
=======================================
Hits 2343 2343
Misses 274 274 Continue to review full report at Codecov.
|
|
Thanks for working on this. Looks like
We should be only changing test, so |
|
Also, can you try reduce the sampling rate of the new wav file ( |
mthrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks!
|
Followup: Remove https://github.com/pytorch/audio/blob/master/test/test_datasets.py#L51 and https://github.com/pytorch/audio/blob/master/test/test_datasets.py#L49 to see if this test works on Windows. @engineerchuan If you have time, would you like to try ^ ? |
Yes I will try. |
Used 'sox -i ' with default 14.4.2 options
soxi output for the wave file I created:
I wasn't sure about whether we need to change Line 111 of torchaudio/datasets/commonvoice.py.