Skip to content

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jun 7, 2023

This is take 2 of: #3383 hopefully without merge conflicts 😅

Warning
This should not be merged until we disable merge queue for next-major as the default behavior is to squash and merge the commits and we'd like to preserve history

joshblack and others added 30 commits May 23, 2023 09:41
* docs: update to storybook v7

* ci: update storybook build command

* docs: fix typescript errors in stories

* chore: update build-storybook custom script

* test(e2e): update root selector for e2e tests

* chore: add storybook/csf dependency

* test: update lockfile test

---------

Co-authored-by: Josh Black <[email protected]>
* Adding example of focus bug

* Not using focusInStrategy when clicking

* Clearing mousedown state correctly

* Adding changeset

* Removing unused import

* Moving mouseup handler
* feat(npm): add experimental entrypoint

* chore: add changeset

---------

Co-authored-by: Josh Black <[email protected]>
* Make placeholderText prop optional

* Add `inputLabel` prop

* Add filter input description

* Create early-beds-whisper.md

* Document inputLabel prop

* Update src/SelectPanel/SelectPanel.docs.json

* Update generated/components.json

---------

Co-authored-by: colebemis <[email protected]>
* Add a title prop to SelectPanel

* Update generated/components.json

* Create small-queens-vanish.md

* Allow title to be ReactElement

* Update SelectPanel stories

* Update generated/components.json

* Update snapshots

---------

Co-authored-by: colebemis <[email protected]>
* SelectPanel: Announce filter changes to screenreaders

* Create rare-humans-watch.md

* Update formatting
* remove chroma.valid to drop chroma-js dependency

* Create rotten-dogs-hang.md
* Update accessibility-alt-text-bot.yml

### What

The accessibility-alt-text-bot workflow does not have permissions to write a comment on an issue. This is likely due to how permissions are setup in this repo. In order to keep permissions, at the repo level, unchanged, we need to add permission directly to the workflow. 

I also took this as an opportunity to bump the alt-text-bot version and give you access to reminders in discussions

* format

* add  contents

* add  contents
* Remove aria-hidden=true from spans with required asterisk

* Create pink-beds-fetch.md

---------

Co-authored-by: Cole Bemis <[email protected]>
* Update `PageLayout` docs around `<main>` usage

* Update generated/components.json

* Fix links

---------

Co-authored-by: TylerJDev <[email protected]>
* Fix NavLIst.Group dividers

* Use first-of-type instead of first-child

* Update snapshots and stories
…tionList. (#3247)

* Update FilteredActionList to use non-deprecated ActionList.

* Use non-deprecated ActionList in FilteredActionList.

* Fix a11y issues in FilteredActionList story.

* Add prop to hide selection component if needed.

* Remove unused hook import.

* Get SavedReplies to look as it did with deprecated ActionList.

* Fix failing test.

* Create weak-jokes-chew.md

* Update generated/components.json

* Fix themePreval snapshot.

* Linting fixes.

* Fix type-check errors.

* Update themePreval snapshot again.

* Fix themePreval snapshot to match origin. Unsure why it's not generating the same way.

* Hide selections in MarkdownEditor saved replies.

* Remove hideSelection prop and add defaultRenderFn to FilteredActionList so these don't have to be defined manually everywhere.

* Fix selection rendering (needed explicit selected boolean) and fix SelectPanel docs.

* Pass selectionVariant illegally to SelectPanel in src/MarkdownEditor/_SavedReplies.tsx so Selection components don't render.

* Remove remaining references of hideSelection prop.

* Update changeset to reflect that changes impact SelectPanel.

* Remove renderFn prop from SelectPanel and use default for FilteredActionList, which seems to cover most cases.

* Fix truncation in SavedReplies descriptions.

* Update generated/components.json

* Fix linting error.

* Don't make renderFn a prop (if we need to make this configurable, we can expose it later. Use maxWidth 100% for SavedReplies truncation.

* Use showDividers prop in SelectPanel story.

* Formatting.

* Add temporary support for showItemDividers prop to SelectPanel to keep backwards compatibility.

* Support passing deprecated showItemDividers prop in ActionList.

---------

Co-authored-by: radglob <[email protected]>
* add fallback plugin

* Update rollup.config.js

Co-authored-by: Josh Black <[email protected]>

* remove fallbacks from source

* add back conflict free package-lock

* use lockfileVersion 3

---------

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Siddharth Kshetrapal <[email protected]>
#3332)

* move theme deps from devDependencies

* Create eleven-sloths-laugh.md
Bumps [terser](https://github.com/terser/terser) from 5.16.1 to 5.17.6.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](terser/terser@v5.16.1...v5.17.6)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3337)

Bumps [micromark-extension-mdxjs](https://github.com/micromark/micromark-extension-mdxjs) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/micromark/micromark-extension-mdxjs/releases)
- [Commits](micromark/micromark-extension-mdxjs@1.0.0...1.0.1)

---
updated-dependencies:
- dependency-name: micromark-extension-mdxjs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…18 (#3338)

Bumps [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials) from 7.0.12 to 7.0.18.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/v7.0.18/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.18/code/addons/essentials)

---
updated-dependencies:
- dependency-name: "@storybook/addon-essentials"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(deps-dev): bump prettier from 2.8.1 to 2.8.8

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.8.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.1...2.8.8)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: run prettier

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
…`ActionList.Item`'s `onSelect` handler by @gr2m (#3346)

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163)

* test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler

Failing test for #3162

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler

* add storybook example: Delayed Menu Close

* update docs

* docs: changeset

* Update changelog

---------

Co-authored-by: Siddharth Kshetrapal <[email protected]>

* Update generated/components.json

---------

Co-authored-by: Gregor Martynus <[email protected]>
Co-authored-by: siddharthkp <[email protected]>
* add caret

* Create fluffy-pants-play.md
* changes alignment of validation message icon

* Create .changeset/big-days-obey.md

* updates snapshots

* updates snapshots again

* refactors layout styles

* test(vrt): update snapshots

---------

Co-authored-by: joshblack <[email protected]>
dependabot bot and others added 20 commits June 5, 2023 14:13
….0 (#3356)

Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/HEAD/packages/node-resolve) from 15.0.2 to 15.1.0.
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v15.1.0/packages/node-resolve)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-node-resolve"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3358)

Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.21.0 to 7.21.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-preset-typescript)

---
updated-dependencies:
- dependency-name: "@babel/preset-typescript"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3359)

Bumps [@github/relative-time-element](https://github.com/github/relative-time-element) from 4.2.1 to 4.3.0.
- [Release notes](https://github.com/github/relative-time-element/releases)
- [Commits](github/relative-time-element@v4.2.1...v4.3.0)

---
updated-dependencies:
- dependency-name: "@github/relative-time-element"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add typescript-plugin-css-modules, remove globals

* sigh, no type-safety in ci yet
* remove snapshot change

* Delete silly-pets-work.md

Not needed
* allows up to 4 levels of nesting for the NavList

* adds changeset

* Update src/NavList/NavList.tsx

Co-authored-by: Cole Bemis <[email protected]>

* updates snapshots

---------

Co-authored-by: Cole Bemis <[email protected]>
…on if parent is not interactive. (#3284)

* Using button as the underlying tag for ActionList.Item content.

* Fix subnav layout.

* Changing ActionList content to button if the top-level is not a button. ActionMenu is busted.

* Fix issue where ActionList.Item content would render as a button inside ActionMenu, breaking keyboard navigation.

* Create purple-crabs-matter.md

* test(vrt): update snapshots

* Fix bug with MenuContext not being exported properly.

* Fix color violation in ActionList.Item.

* Formatting, update snapshots.

* test(vrt): update snapshots

* Fix a11y violation in ActionList story.

* Formatting.

* Fix ts-ignore comment.

* Adjust line-height when button is rendered.

* Revert "test(vrt): update snapshots"

This reverts commit ba6d863.

* Revert "test(vrt): update snapshots"

This reverts commit 31d5358.

* Update snapshots.

* Remove flexGrow from ActionList.Item to remove extra 1px vertical height.

* Set padding to 0 and put flexGrow back to fix padding issue for ActionList buttons.

* Fix ActionList text wrap story.

* Fix underlinenav story by checking ActionList.Item if as prop is a.

* Update snapshots and formatting.

* Update snapshots.

* If ActionList.Item content is rendered as a button, remove tabIndex from li and fix padding.

* Fix various layout edge cases.

* ts-ignore event handlers on ItemWrapper.

* Update snapshots.

* Revert fontWeight config that differed from production docs.

* Pass selectionVariant prop illegally in UnderlineNav story to fix issue with Selection spans showing up.

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler by @gr2m (#3346)

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler (#3163)

* test: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`'s `onSelect` handler

Failing test for #3162

* fix: prevent closing menu when `event.preventDefault()` is called on `ActionList.Item`ߴs `onSelect` handler

* add storybook example: Delayed Menu Close

* update docs

* docs: changeset

* Update changelog

---------

Co-authored-by: Siddharth Kshetrapal <[email protected]>

* Update generated/components.json

---------

Co-authored-by: Gregor Martynus <[email protected]>
Co-authored-by: siddharthkp <[email protected]>

* Check for tabIndex value in isTopLevelInteractive.

* Reference styles in updated menuProps.

* Updated snapshots.

* Fix padding setting instead of using values from styles, which are inverted.

* Update snapshots.

---------

Co-authored-by: radglob <[email protected]>
Co-authored-by: Gregor Martynus <[email protected]>
Co-authored-by: siddharthkp <[email protected]>
* corrects disabled button icon colors

* Create dry-olives-rule.md
@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 35d0b83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.74 KB (+0.19% 🔺)
dist/browser.umd.js 102.24 KB (+0.11% 🔺)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed! 🤞🏻

@joshblack joshblack closed this Jun 8, 2023
@joshblack joshblack deleted the chore/update-next-major-with-latest branch June 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.