Skip to content

Conversation

agreenberry
Copy link
Contributor

Describe your changes here.

Closes #3230 for _CheckboxOrRadioGroupContext

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@agreenberry agreenberry requested review from a team and joshblack May 8, 2023 20:57
@agreenberry agreenberry linked an issue May 8, 2023 that may be closed by this pull request
12 tasks
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

⚠️ No Changeset found

Latest commit: fdae1f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 121.63 KB (-0.01% 🔽)
dist/browser.umd.js 121.88 KB (-0.01% 🔽)

@agreenberry agreenberry temporarily deployed to github-pages May 8, 2023 21:04 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3263 May 8, 2023 21:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3263 May 8, 2023 21:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3263 May 8, 2023 21:07 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a question for the snapshot changes 👀

@agreenberry agreenberry force-pushed the 3230-refactor-internal-components-into-internal-folder branch from 563d791 to 2b8e10f Compare May 9, 2023 18:03
@agreenberry agreenberry requested a review from joshblack May 9, 2023 18:04
@github-actions github-actions bot temporarily deployed to storybook-preview-3263 May 9, 2023 18:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3263 May 9, 2023 18:14 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label May 9, 2023
@agreenberry agreenberry added this pull request to the merge queue Jun 5, 2023
Merged via the queue into main with commit c10229b Jun 5, 2023
@agreenberry agreenberry deleted the 3230-refactor-internal-components-into-internal-folder branch June 5, 2023 19:17
@agreenberry agreenberry linked an issue Jun 5, 2023 that may be closed by this pull request
12 tasks
@agreenberry agreenberry linked an issue Jun 5, 2023 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor internal components into internal folder

2 participants