-
Notifications
You must be signed in to change notification settings - Fork 640
Add type-safety for classnames in vs code #3347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 🥳 For the type error, do we need something like: https://www.npmjs.com/package/typescript-plugin-css-modules#user-content-custom-definitions or is what you had before in global.d.ts good to use? 👀
We do :( (updated) I was hoping we wouldn't need it, only to realise tsc doesn't load plugins |
size-limit report 📦
|
Added type-safety for classnames with typescript-plugin-css-modules in the editor.
Unfortunately, tsc doesn't load plugins yet, so we don't get typechecks for classnames in CI and are stuck with declaring loose definitions in
global.d.tsfor now.Note: Make sure your editor is using the workspace version of typescript to use the plugin. See typescript docs