Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
285f66d
ci(release-schedule): update format for previous issue id
joshblack May 23, 2023
112fd2c
ci(release-schedule): use tagged template literals for assignees row
joshblack May 23, 2023
ac698b5
docs: update to storybook v7 (#3298)
joshblack May 23, 2023
5d06738
Jdrush89/tree focus bug (#3300)
jdrush89 May 23, 2023
e71d928
feat(npm): add experimental entrypoint (#3295)
joshblack May 24, 2023
d82f505
ci: release notification (#3318)
gr2m May 24, 2023
56c9dd2
SelectPanel: Add filter input label and description (#3312)
colebemis May 24, 2023
00cf2e3
SelectPanel: Add `title` prop (#3311)
colebemis May 24, 2023
2cf7cdd
SelectPanel: Announce changes to screen readers (#3316)
colebemis May 24, 2023
9e7681c
chore(dependencies): update @typescript-eslint/* (#3307)
joshblack May 25, 2023
3ece2f6
Remove chroma-js dependency (#3325)
siddharthkp May 25, 2023
a71bb60
Update accessibility-alt-text-bot.yml (#3326)
kendallgassner May 25, 2023
47b7ea0
Remove aria-hidden=true from spans with required asterisk (#3320)
adrianababakanian May 25, 2023
e1904b2
Update `PageLayout` docs around `<main>` usage (#3323)
TylerJDev May 25, 2023
b1395e9
ci: update ci workflow to run against next-major branch (#3329)
joshblack May 25, 2023
1fd6d32
NavList: Fix group dividers (#3328)
colebemis May 25, 2023
e865e3e
Refactor FilteredActionList to address a11y violations and use new Ac…
radglob May 26, 2023
60ebd51
Add PostCSS color var fallback for upcoming CSS work (#3278)
langermank May 26, 2023
ff8c685
Move theme dependencies on lodash from devDependencies to dependencie…
siddharthkp May 26, 2023
30c7c97
chore(deps-dev): bump terser from 5.16.1 to 5.17.6 (#3336)
dependabot[bot] May 30, 2023
8d4f5b6
chore(deps-dev): bump micromark-extension-mdxjs from 1.0.0 to 1.0.1 (…
dependabot[bot] May 30, 2023
e64ecbc
chore(deps-dev): bump @storybook/addon-essentials from 7.0.12 to 7.0.…
dependabot[bot] May 30, 2023
536a93b
ci(vrt): update build storybook step (#3333)
joshblack May 30, 2023
1665a1b
chore(deps-dev): bump prettier from 2.8.1 to 2.8.8 (#3335)
dependabot[bot] May 30, 2023
6304923
fix: prevent closing menu when `event.preventDefault()` is called on …
siddharthkp May 31, 2023
524120c
Loosen `@primitives` dependency (#3350)
langermank May 31, 2023
92f24a7
Bump alt-text-bot: get alt text reminders on discussion comments (#3351)
kendallgassner Jun 1, 2023
3ad5648
Changes alignment of form control validation message icon (#3121)
mperrotti Jun 1, 2023
1fc33cb
Update release-schedule.yml (#3342)
joshblack Jun 2, 2023
a396ff4
Update release-schedule.yml (#3345)
joshblack Jun 2, 2023
cf40a16
chore(deps-dev): bump @rollup/plugin-node-resolve from 15.0.2 to 15.1…
dependabot[bot] Jun 5, 2023
a1a19d5
chore(deps-dev): bump @babel/preset-typescript from 7.21.0 to 7.21.5 …
dependabot[bot] Jun 5, 2023
e5876e8
chore(deps): bump @github/relative-time-element from 4.2.1 to 4.3.0 (…
dependabot[bot] Jun 5, 2023
6c06f0e
Update release-schedule.yml (#3363)
joshblack Jun 5, 2023
4c6d9ff
Add type-safety for classnames in vs code (#3347)
siddharthkp Jun 5, 2023
c10229b
3230 refactor internal components into internal folder (#3263)
agreenberry Jun 5, 2023
aaec363
refactor(TextInputWrapper): moved to internal (#3375)
agreenberry Jun 6, 2023
8a53318
move options (#3382)
langermank Jun 6, 2023
00b95d5
refactor(InputCaption): moved to internal (#3369)
agreenberry Jun 6, 2023
17934f9
Allow ActionMenu in custom overlay props example to be dismissed via …
camertron Jun 6, 2023
cbc1ab8
refactor(ValidationAnimationContainer): moved to internal (#3377)
agreenberry Jun 6, 2023
9669267
refactor(InputLabel): moved to internal (#3370)
agreenberry Jun 6, 2023
a6b4169
Revert "Refactor FilteredActionList to address a11y violations and us…
joshblack Jun 6, 2023
786013e
Allow up to 4 levels of nesting for the NavList (#3343)
mperrotti Jun 6, 2023
08d7d5d
Refactor(ActionList): ActionList.Item should render content as a butt…
radglob Jun 6, 2023
88f87bf
refactor(UnstyledTextInput): moved to internal (#3376)
agreenberry Jun 6, 2023
7d8247e
refactor(InputValidation): moved to internal (#3371)
agreenberry Jun 6, 2023
c8095a1
Correct disabled Button icon fill colors (#3368)
mperrotti Jun 7, 2023
c154d21
Revert "Update `next-major` with changes from `main` (#3354)"
joshblack Jun 7, 2023
35d0b83
Merge branch 'main' of github.com:primer/react into next-major
joshblack Jun 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-olives-rule.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Correct disabled Button icon fill colors
5 changes: 5 additions & 0 deletions .changeset/little-hairs-train.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Allows up to 4 levels of nesting in the NavList component.
5 changes: 5 additions & 0 deletions .changeset/purple-crabs-matter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Refactor(ActionList): ActionList.Item should render content as a button if parent is not interactive.
5 changes: 0 additions & 5 deletions .changeset/weak-jokes-chew.md

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/release-schedule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Release Schedule
on:
workflow_dispatch:
schedule:
- cron: '30 13 * * MON'
- cron: '0 16 * * MON'

concurrency:
group: ${{ github.workflow }}-${{ github.event.workflow_run.head_branch }}
Expand Down
30 changes: 30 additions & 0 deletions docs/content/NavList.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,36 @@ If a `NavList.Item` contains a `NavList.SubNav`, the `NavList.Item` will render

</Note>

### With nested sub-items

```jsx live drafts
<NavList>
<NavList.Item href="/branches">Branches</NavList.Item>
<NavList.Item href="/tags">Tags</NavList.Item>
<NavList.Item>
Actions
<NavList.SubNav>
<NavList.Item href="/actions" aria-current="page">
General
</NavList.Item>
<NavList.Item href="/actions/runners">
Runners
<NavList.SubNav>
<NavList.Item href="/actions/runners/runner-1">Runner 1</NavList.Item>
<NavList.Item href="/actions/runners/runner-2">Runner 2</NavList.Item>
</NavList.SubNav>
</NavList.Item>
</NavList.SubNav>
</NavList.Item>
</NavList>
```

<Note variant="warning">

We only allow for up to 4 levels of nested subnavs. If more than 4 levels is required, it's a good sign that the navigation design needs to be rethought.

</Note>

### With a divider

```jsx live drafts
Expand Down
26 changes: 14 additions & 12 deletions docs/content/SelectPanel.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,20 @@ A `SelectPanel` provides an anchor that will open an overlay with a list of sele

```javascript live noinline
function getColorCircle(color) {
return (
<Box
borderWidth="1px"
borderStyle="solid"
bg={color}
borderColor={color}
width={14}
height={14}
borderRadius={10}
margin="auto"
/>
)
return function () {
return (
<Box
borderWidth="1px"
borderStyle="solid"
bg={color}
borderColor={color}
width={14}
height={14}
borderRadius={10}
margin="auto"
/>
)
}
}

const items = [
Expand Down
2 changes: 1 addition & 1 deletion generated/components.json
Original file line number Diff line number Diff line change
Expand Up @@ -3626,7 +3626,7 @@
"stories": [
{
"id": "components-selectpanel--default",
"code": "() => {\n const [selected, setSelected] = React.useState<ItemInput[]>([\n items[0],\n items[1],\n ])\n const [filter, setFilter] = React.useState('')\n const filteredItems = items.filter((item) =>\n item.text.toLowerCase().startsWith(filter.toLowerCase()),\n )\n const [open, setOpen] = useState(false)\n return (\n <>\n <h1>Multi Select Panel</h1>\n <div>Please select labels that describe your issue:</div>\n <SelectPanel\n title=\"Select labels\"\n renderAnchor={({\n children,\n 'aria-labelledby': ariaLabelledBy,\n ...anchorProps\n }) => (\n <Button\n trailingAction={TriangleDownIcon}\n aria-labelledby={` ${ariaLabelledBy}`}\n {...anchorProps}\n >\n {children ?? 'Select Labels'}\n </Button>\n )}\n placeholderText=\"Filter labels\"\n open={open}\n onOpenChange={setOpen}\n items={filteredItems}\n selected={selected}\n onSelectedChange={setSelected}\n onFilterChange={setFilter}\n overlayProps={{\n width: 'small',\n height: 'xsmall',\n }}\n />\n </>\n )\n}"
"code": "() => {\n const [selected, setSelected] = React.useState<ItemInput[]>([\n items[0],\n items[1],\n ])\n const [filter, setFilter] = React.useState('')\n const filteredItems = items.filter((item) =>\n item.text.toLowerCase().startsWith(filter.toLowerCase()),\n )\n const [open, setOpen] = useState(false)\n return (\n <>\n <h1>Multi Select Panel</h1>\n <div>Please select labels that describe your issue:</div>\n <SelectPanel\n title=\"Select labels\"\n renderAnchor={({\n children,\n 'aria-labelledby': ariaLabelledBy,\n ...anchorProps\n }) => (\n <Button\n trailingAction={TriangleDownIcon}\n aria-labelledby={` ${ariaLabelledBy}`}\n {...anchorProps}\n >\n {children ?? 'Select Labels'}\n </Button>\n )}\n placeholderText=\"Filter labels\"\n open={open}\n onOpenChange={setOpen}\n items={filteredItems}\n selected={selected}\n onSelectedChange={setSelected}\n onFilterChange={setFilter}\n showItemDividers={true}\n overlayProps={{\n width: 'small',\n height: 'xsmall',\n }}\n />\n </>\n )\n}"
}
],
"props": [
Expand Down
Loading