Skip to content

3230 Refactor internal components - TextInputWrapper #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

3230 Refactor internal components - TextInputWrapper #3375

merged 1 commit into from
Jun 6, 2023

Conversation

agreenberry
Copy link
Contributor

@agreenberry agreenberry commented Jun 5, 2023 •
edited
Loading

This is part of the refactor per ADR https://github.com/primer/react/blob/main/contributor-docs/adrs/adr-016-internal-modules.md

Closes part of #3230

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@agreenberry agreenberry requested review from a team and broccolinisoup June 5, 2023 21:12
@agreenberry agreenberry linked an issue Jun 5, 2023 that may be closed by this pull request
Refactor internal components into internal folder #3230
Closed
12 tasks
@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

⚠️ No Changeset found

Latest commit: 4fc41bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agreenberry agreenberry mentioned this pull request Jun 5, 2023
Closed
12 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.67 KB (0%)
dist/browser.umd.js 102.23 KB (-0.01% 🔽)

@agreenberry agreenberry added the skip changeset This change does not need a changelog label Jun 5, 2023
@agreenberry agreenberry enabled auto-merge June 5, 2023 22:25
broccolinisoup
broccolinisoup approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 😊

@agreenberry agreenberry added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit aaec363 Jun 6, 2023
@agreenberry agreenberry deleted the 3230-refactor-internal-components-TextInputWrapper branch June 6, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor internal components into internal folder

2 participants

@agreenberry @broccolinisoup