Skip to content

Conversation

agreenberry
Copy link
Contributor

@agreenberry agreenberry commented Jun 5, 2023

This is part of the refactor per ADR https://github.com/primer/react/blob/main/contributor-docs/adrs/adr-016-internal-modules.md

Closes part of #3230

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@agreenberry agreenberry requested a review from a team June 5, 2023 19:30
@agreenberry agreenberry linked an issue Jun 5, 2023 that may be closed by this pull request
12 tasks
@agreenberry agreenberry requested a review from siddharthkp June 5, 2023 19:30
@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

⚠️ No Changeset found

Latest commit: aeb9081

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agreenberry agreenberry added the skip changeset This change does not need a changelog label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.82 KB (0%)
dist/browser.umd.js 102.3 KB (0%)

@agreenberry agreenberry temporarily deployed to github-pages June 5, 2023 19:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3371 June 5, 2023 19:37 Inactive
@agreenberry agreenberry enabled auto-merge June 5, 2023 22:25
@agreenberry agreenberry added this pull request to the merge queue Jun 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 6, 2023
@agreenberry agreenberry temporarily deployed to github-pages June 6, 2023 16:19 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3371 June 6, 2023 16:19 Inactive
@agreenberry agreenberry temporarily deployed to github-pages June 6, 2023 19:19 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3371 June 6, 2023 19:20 Inactive
@agreenberry agreenberry enabled auto-merge June 6, 2023 21:45
@agreenberry agreenberry added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit 7d8247e Jun 6, 2023
@agreenberry agreenberry deleted the 3230-refactor-internal-components-InputValidation branch June 6, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor internal components into internal folder

2 participants