Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add support for zx_channel_write_etc and zx_channel_read_etc. #26050

Merged
merged 1 commit into from
May 13, 2021
Merged

Add support for zx_channel_write_etc and zx_channel_read_etc. #26050

merged 1 commit into from
May 13, 2021

Conversation

@chandarrengoog
Copy link
Contributor

@chandarrengoog chandarrengoog commented May 10, 2021 •
edited
Loading

Add support for System.channelWriteEtc and System.channelQueryAndReadEtc.

These use the zx_channel_write_etc and zx_channel_read_etc syscalls, which implements the majority of https://fxbug.dev/68600.

Also add HandleDisposition, HandleInfoResult, and ReadEtcResult classes to dart:zircon's API surface.

I've added tests to channel_test and handle_disposition_test, and ran them locally.

Relevant bugs: https://fxbug.dev/68600

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 10, 2021
@chandarrengoog chandarrengoog force-pushed the zircon branch 2 times, most recently from d1f7562 to f32920f Compare May 12, 2021 00:11
@chandarrengoog chandarrengoog marked this pull request as ready for review May 12, 2021 00:12
arbreng
arbreng reviewed May 12, 2021
View reviewed changes
arbreng
arbreng reviewed May 12, 2021
View reviewed changes
@chandarrengoog chandarrengoog force-pushed the zircon branch 2 times, most recently from 24a440e to 8e2a5dd Compare May 12, 2021 18:23
@chandarrengoog chandarrengoog requested a review from arbreng May 12, 2021 18:25
@chandarrengoog chandarrengoog added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed Work in progress (WIP) Not ready (yet) for review! labels May 13, 2021
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 13, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows UWP Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 13, 2021
@chandarrengoog
Add support for System.channelWriteEtc and System.channelQueryAndRead…
ff251bd 
…Etc.

These use the zx_channel_write_etc and zx_channel_read_etc syscalls,
which implements the majority of https://fxbug.dev/68600.

Also add HandleDisposition, HandleInfoResult, and ReadEtcResult classes
to dart:zircon's API surface.

I've added tests to channel_test and handle_disposition_test, and ran
them locally.
@chandarrengoog chandarrengoog added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 13, 2021
@fluttergithubbot fluttergithubbot merged commit 2ef73bf into flutter:master May 13, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
@engine-flutter-autoroll
2ef73bf Add support for System.channelWriteEtc and System.channelQuer…
73200ad 
…yAndReadEtc. (flutter/engine#26050)
@chandarrengoog chandarrengoog deleted the zircon branch May 14, 2021 02:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
@engine-flutter-autoroll
2ef73bf Add support for System.channelWriteEtc and System.channelQuer…
0c84089 
…yAndReadEtc. (flutter/engine#26050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
@engine-flutter-autoroll
2ef73bf Add support for System.channelWriteEtc and System.channelQuer…
2244f17 
…yAndReadEtc. (flutter/engine#26050)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
@engine-flutter-autoroll
2ef73bf Add support for System.channelWriteEtc and System.channelQuer…
5134e36 
…yAndReadEtc. (flutter/engine#26050)
cbracken pushed a commit to flutter/flutter that referenced this pull request May 14, 2021
@engine-flutter-autoroll
Roll Engine from 4900682 to 0507f4a (15 revisions) (#82510)
b70f20b 
* 0f28cd6 [uwptool] Add uninstall command (flutter/engine#26122)

* cf18983 Fix composition when multiple platform views and layers are combined  (flutter/engine#25900)

* c118a13 Add missing semantics flag for embedder (flutter/engine#25932)

* e0418d2 [fuchsia] rename SessionConnection to DefaultSessionConnection (flutter/engine#26104)

* 589f514 add `TextLeadingDistribution` to webui `TextStyle` (flutter/engine#25777)

* 2ef73bf Add support for System.channelWriteEtc and System.channelQueryAndReadEtc. (flutter/engine#26050)

* 247d1d9 Roll Fuchsia Linux SDK from WYD7atCH7... to uffIHSwYt... (flutter/engine#26131)

* 7e34f1f Revert "SceneBuilder.addPicture returns the layer (#26074)" (flutter/engine#26133)

* 26a48f1 Roll Dart SDK from c119194b23d9 to ba8506bdcef7 (2 revisions) (flutter/engine#26135)

* 0fc5600 Fix GIR transfer annotation

* b8072ae Roll Skia from ca9f6a855071 to 3193a04b09d8 (21 revisions) (flutter/engine#26136)

* 2071b03 Roll Fuchsia Mac SDK from mdsssGtoC... to y3xw-lhxW... (flutter/engine#26137)

* 6fb2f94 web: improve engine dev cycle on Windows (flutter/engine#25812)

* 8773295 Windows: UWP ViewController accepts a CoreApplicationView and exposes to plugins (flutter/engine#25879)

* 0507f4a Revert "Fix composition when multiple platform views and layers are combined  (#25900)" (flutter/engine#26142)
@chandarrengoog chandarrengoog mentioned this pull request Aug 20, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arbreng arbreng Awaiting requested review from arbreng

1 more reviewer

@chaselatta chaselatta chaselatta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-fuchsia waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chandarrengoog @fluttergithubbot @chaselatta @arbreng