Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 13, 2021

Adds an uninstall command that uninstalls the specified application by
its package family name.

This currently attempts to remove for all users, but in future, we may
want to restrict install and uninstall to the current user only.

Also renames ApplicationStore::GetInstalledApplications() to
ApplicationStore::GetApps()

Issue: flutter/flutter#82399

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

Adds an uninstall command that uninstalls the specified application by
its package family name.

This currently attempts to remove for all users, but in future, we may
want to restrict install and uninstall to the current user only.

Also renames ApplicationStore::GetInstalledApplications() to
ApplicationStore::GetApps()
@cbracken cbracken merged commit 0f28cd6 into flutter:master May 13, 2021
@cbracken cbracken deleted the uwptool-uninstall branch May 13, 2021 18:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2021
cbracken pushed a commit to flutter/flutter that referenced this pull request May 13, 2021
* 0f28cd6 [uwptool] Add uninstall command (flutter/engine#26122)

* cf18983 Fix composition when multiple platform views and layers are combined  (flutter/engine#25900)

* c118a13 Add missing semantics flag for embedder (flutter/engine#25932)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
cbracken pushed a commit to flutter/flutter that referenced this pull request May 14, 2021
* 0f28cd6 [uwptool] Add uninstall command (flutter/engine#26122)

* cf18983 Fix composition when multiple platform views and layers are combined  (flutter/engine#25900)

* c118a13 Add missing semantics flag for embedder (flutter/engine#25932)

* e0418d2 [fuchsia] rename SessionConnection to DefaultSessionConnection (flutter/engine#26104)

* 589f514 add `TextLeadingDistribution` to webui `TextStyle` (flutter/engine#25777)

* 2ef73bf Add support for System.channelWriteEtc and System.channelQueryAndReadEtc. (flutter/engine#26050)

* 247d1d9 Roll Fuchsia Linux SDK from WYD7atCH7... to uffIHSwYt... (flutter/engine#26131)

* 7e34f1f Revert "SceneBuilder.addPicture returns the layer (#26074)" (flutter/engine#26133)

* 26a48f1 Roll Dart SDK from c119194b23d9 to ba8506bdcef7 (2 revisions) (flutter/engine#26135)

* 0fc5600 Fix GIR transfer annotation

* b8072ae Roll Skia from ca9f6a855071 to 3193a04b09d8 (21 revisions) (flutter/engine#26136)

* 2071b03 Roll Fuchsia Mac SDK from mdsssGtoC... to y3xw-lhxW... (flutter/engine#26137)

* 6fb2f94 web: improve engine dev cycle on Windows (flutter/engine#25812)

* 8773295 Windows: UWP ViewController accepts a CoreApplicationView and exposes to plugins (flutter/engine#25879)

* 0507f4a Revert "Fix composition when multiple platform views and layers are combined  (#25900)" (flutter/engine#26142)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants