Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Apr 28, 2021

  • Add felt.bat that snapshots felt.dart (removes ~10 seconds per command invocation)
  • Remove no longer necessary extra pub get in the test runner (removes ~5 seconds per felt test invocation)
  • Build tests with -O0 for less aggressive inlining (improves stack traces)

@yjbanov yjbanov requested a review from mdebbar April 28, 2021 16:30
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 28, 2021
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@yjbanov yjbanov requested a review from ferhatb April 28, 2021 17:00
CD %FLUTTER_DIR%
FOR /F "tokens=1 delims=:" %%a in ('git rev-parse HEAD') DO SET REVISION=%%a

:: Uncomment for debugging the values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add TODO: Update LUCI to use felt.bat and remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yjbanov yjbanov force-pushed the windows-felt branch 3 times, most recently from 3bc7a49 to 917a3dc Compare May 7, 2021 18:34
@yjbanov yjbanov merged commit 6fb2f94 into flutter:master May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2021
cbracken pushed a commit to flutter/flutter that referenced this pull request May 14, 2021
* 0f28cd6 [uwptool] Add uninstall command (flutter/engine#26122)

* cf18983 Fix composition when multiple platform views and layers are combined  (flutter/engine#25900)

* c118a13 Add missing semantics flag for embedder (flutter/engine#25932)

* e0418d2 [fuchsia] rename SessionConnection to DefaultSessionConnection (flutter/engine#26104)

* 589f514 add `TextLeadingDistribution` to webui `TextStyle` (flutter/engine#25777)

* 2ef73bf Add support for System.channelWriteEtc and System.channelQueryAndReadEtc. (flutter/engine#26050)

* 247d1d9 Roll Fuchsia Linux SDK from WYD7atCH7... to uffIHSwYt... (flutter/engine#26131)

* 7e34f1f Revert "SceneBuilder.addPicture returns the layer (#26074)" (flutter/engine#26133)

* 26a48f1 Roll Dart SDK from c119194b23d9 to ba8506bdcef7 (2 revisions) (flutter/engine#26135)

* 0fc5600 Fix GIR transfer annotation

* b8072ae Roll Skia from ca9f6a855071 to 3193a04b09d8 (21 revisions) (flutter/engine#26136)

* 2071b03 Roll Fuchsia Mac SDK from mdsssGtoC... to y3xw-lhxW... (flutter/engine#26137)

* 6fb2f94 web: improve engine dev cycle on Windows (flutter/engine#25812)

* 8773295 Windows: UWP ViewController accepts a CoreApplicationView and exposes to plugins (flutter/engine#25879)

* 0507f4a Revert "Fix composition when multiple platform views and layers are combined  (#25900)" (flutter/engine#26142)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants