This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Improve FakeSession & add tests #28139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
added
affects: tests
platform-fuchsia
tech-debt
Member
|
@jaeheon It seem you are not a collaborator on the Flutter GitHub organization. Can you follow the steps in go/flutter-onboarding to become one please? Happy to provide the endorsement. |
chinmaygarde
approved these changes
Aug 19, 2021
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Just adding an approval till @jaeheon gets access.
Contributor
|
Thank you Chinmay. I accepted hixie's invite. |
chandarrengoog
approved these changes
Aug 20, 2021
| fidl::InterfaceHandle<fuchsia::sysmem::BufferCollectionToken> token) { | ||
| NotImplemented_("RegisterBufferCollection"); // TODO | ||
| zx_koid_t token_koid = GetKoid(token.channel().get()); | ||
| auto [_, buffer_success] = |
Contributor
There was a problem hiding this comment.
nice! I didn't know that c++ can unpack values like this.
Contributor
Author
There was a problem hiding this comment.
Only since C++17: https://en.cppreference.com/w/cpp/language/structured_binding
Contributor
|
Please address comments and merge at your discretion. |
jaeheon
approved these changes
Aug 20, 2021
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for resources to FakeSession, and add tests to verify its behavior. This is a precursor to a patch adding unit tests for FuchsiaExternalViewEmbedder and PlatformView
Test: Added fake_session_unittests
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=79873