Windows: UWP ViewController accepts a CoreApplicationView and exposes to plugins #25879
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @cbracken. If you are done with the engine tree firefighting, can you take a look at this please? |
| ABI::Windows::ApplicationModel::Core::CoreApplicationView* GetNativeWindow() { | ||
| return FlutterDesktopViewGetCoreApplicationView(view_); | ||
| } | ||
| #else |
There was a problem hiding this comment.
Question (here and below) -- if these headers are included by end-user applications, how do we know they've got WINUWP defined (or not)? Are we setting it as defined in our build template?
Should we be creating a UWP subclass here? I think the answer is that long-term, yes. We can deal with this in the short term by using a version check against the template like we did back when the the win32/macos templates were changing more frequently. I'll dig up the code for that -- that change will be in the template, not here, so nothing to do on this commit.
… exposes to plugins (flutter/engine#25879)
… exposes to plugins (flutter/engine#25879)
… exposes to plugins (flutter/engine#25879)
* 0f28cd6 [uwptool] Add uninstall command (flutter/engine#26122) * cf18983 Fix composition when multiple platform views and layers are combined (flutter/engine#25900) * c118a13 Add missing semantics flag for embedder (flutter/engine#25932) * e0418d2 [fuchsia] rename SessionConnection to DefaultSessionConnection (flutter/engine#26104) * 589f514 add `TextLeadingDistribution` to webui `TextStyle` (flutter/engine#25777) * 2ef73bf Add support for System.channelWriteEtc and System.channelQueryAndReadEtc. (flutter/engine#26050) * 247d1d9 Roll Fuchsia Linux SDK from WYD7atCH7... to uffIHSwYt... (flutter/engine#26131) * 7e34f1f Revert "SceneBuilder.addPicture returns the layer (#26074)" (flutter/engine#26133) * 26a48f1 Roll Dart SDK from c119194b23d9 to ba8506bdcef7 (2 revisions) (flutter/engine#26135) * 0fc5600 Fix GIR transfer annotation * b8072ae Roll Skia from ca9f6a855071 to 3193a04b09d8 (21 revisions) (flutter/engine#26136) * 2071b03 Roll Fuchsia Mac SDK from mdsssGtoC... to y3xw-lhxW... (flutter/engine#26137) * 6fb2f94 web: improve engine dev cycle on Windows (flutter/engine#25812) * 8773295 Windows: UWP ViewController accepts a CoreApplicationView and exposes to plugins (flutter/engine#25879) * 0507f4a Revert "Fix composition when multiple platform views and layers are combined (#25900)" (flutter/engine#26142)
3 participants
Complete UWP flutter plugin support by changing the
ViewControllerconstructor to accept aCoreApplicationViewand enable UWP plugins to query for that usingFlutterView::GetNativeWindow(). Enables UWP plugins to get access to the backingCoreWindowandCoreTitleBarobjects.flutter/flutter#74155
flutter/flutter#14967
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.