This repository was archived by the owner on Feb 25, 2025. It is now read-only.
add TextLeadingDistribution to webui TextStyle
#25777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
Contributor
Author
|
|
LongCatIsLooong
force-pushed
the
canvaskit-halfleading
branch
from
6fd5308 to
322d5b6
Compare
yjbanov
reviewed
Apr 28, 2021
| ), | ||
| ); | ||
| await testTextStyle( | ||
| 'half leading', |
Contributor
There was a problem hiding this comment.
The first argument is used as part of the golden screenshot file name, so it should be distinct from previous tests.
Contributor
Author
There was a problem hiding this comment.
Ops forgot to push. Fixed.
| skStrutStyle.heightMultiplier = style._height; | ||
| } | ||
|
|
||
| switch (style._leadingDistribution ?? paragraphHeightBehavior?.leadingDistribution) { |
Contributor
There was a problem hiding this comment.
nit: I'd extract the switch expression into a variable. Typically we use "effective" as the prefix for something that's resolved from multiple sources, e.g. effectiveLeadingDistribution.
LongCatIsLooong
force-pushed
the
canvaskit-halfleading
branch
from
49d0312 to
b794586
Compare
LongCatIsLooong
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2021
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2021
* 0f28cd6 [uwptool] Add uninstall command (flutter/engine#26122) * cf18983 Fix composition when multiple platform views and layers are combined (flutter/engine#25900) * c118a13 Add missing semantics flag for embedder (flutter/engine#25932) * e0418d2 [fuchsia] rename SessionConnection to DefaultSessionConnection (flutter/engine#26104) * 589f514 add `TextLeadingDistribution` to webui `TextStyle` (flutter/engine#25777) * 2ef73bf Add support for System.channelWriteEtc and System.channelQueryAndReadEtc. (flutter/engine#26050) * 247d1d9 Roll Fuchsia Linux SDK from WYD7atCH7... to uffIHSwYt... (flutter/engine#26131) * 7e34f1f Revert "SceneBuilder.addPicture returns the layer (#26074)" (flutter/engine#26133) * 26a48f1 Roll Dart SDK from c119194b23d9 to ba8506bdcef7 (2 revisions) (flutter/engine#26135) * 0fc5600 Fix GIR transfer annotation * b8072ae Roll Skia from ca9f6a855071 to 3193a04b09d8 (21 revisions) (flutter/engine#26136) * 2071b03 Roll Fuchsia Mac SDK from mdsssGtoC... to y3xw-lhxW... (flutter/engine#26137) * 6fb2f94 web: improve engine dev cycle on Windows (flutter/engine#25812) * 8773295 Windows: UWP ViewController accepts a CoreApplicationView and exposes to plugins (flutter/engine#25879) * 0507f4a Revert "Fix composition when multiple platform views and layers are combined (#25900)" (flutter/engine#26142)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#72521. This adds half leading as a configurable parameter to
TextStyle.Canvaskit binding changes: https://skia-review.googlesource.com/c/skia/+/398276/6/modules/canvaskit/paragraph_bindings.cpp
new golden files: https://github.com/flutter/goldens/pull/200/files
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.