-
Notifications
You must be signed in to change notification settings - Fork 232
Improved lambda getting started docs #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to avoid adding binary files (the .png) to the repo. Does it make sense to move them to a central repo? Perhaps something like elastic/apm-artifacts, and then pull them into the docs from there?
134KB isn't a lot, but every binary file will be downloaded in every clone from now to the end of time, and if the image changes git can't diff them so now both versions will be included in the repo forever.
If there's another way to include the image I'm up for it. @bmorelli25 do you have an idea what we could do instead of uploading the image in this repo and embedding it in the docs? |
We're already including a lot of content in these docs from |
|
Honestly it's fine if we want to store them here. I just have worked on projects with very large clone times due to binary files and want to at least discuss alternatives before we merge them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs are excellent! Love the tabbed sections for the various ways lambda can be configured!
* Improved lambda getting started docs (#1511) * Improve lambda getting started docs * fixed labels in configure-lambda-widget.asciidoc * match java prereq language * remove img and include from another repo * fixed heading level of step 3 Co-authored-by: bmorelli25 <[email protected]> * ci: packer_cache never fail (#1516) * Fix sanic tests (#1518) Co-authored-by: Alexander Wert <[email protected]> Co-authored-by: bmorelli25 <[email protected]> Co-authored-by: Victor Martinez <[email protected]>
Depends on:
Related: