Skip to content

Conversation

AlexanderWert
Copy link
Member

@AlexanderWert
Copy link
Member Author

Hi @bmorelli25,

this is the Java Agent counter part to elastic/apm-aws-lambda#158.

Corresponding Node.js Agent and Python Agent PRs will follow soon.

This PR contains some dependencies on elastic/apm-aws-lambda#158 - is something needed in addition to make those dependencies / includes / links work properly, once elastic/apm-aws-lambda#158 is merged?

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-31T21:07:07.128+0000

  • Duration: 3 min 21 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@bmorelli25
Copy link
Member

bmorelli25 commented Mar 29, 2022

Before this will pass docs ci, three things need to happen:

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview is looking good! Here are some thoughts and comments.

@felixbarny
Copy link
Member

The guide assumes that users have an APM Server set up already. We might want to add a step that links to https://www.elastic.co/guide/en/apm/server/current/getting-started-apm-server.html#_hosted_elasticsearch_service so that users that just get started know where to go. We should also add a recommendation that users are recommended to create a cluster on ESS in the same region as their Lambda function.

@AlexanderWert
Copy link
Member Author

AlexanderWert commented Mar 30, 2022

@bmorelli25 The build docs are failing now because I added a back link to the Lambda extension {apm-guide-ref}/aws-lambda-arch.html. Will this resolve when elastic/apm-aws-lambda#158 is merged or is something in addition needed (e.g. cherry picking like you did for {apm-guide-ref}/aws-lambda-config-options.html) ?

@bmorelli25
Copy link
Member

@bmorelli25 The build docs are failing now because I added a back link to the Lambda extension {apm-guide-ref}/aws-lambda-arch.html. Will this resolve when elastic/apm-aws-lambda#158 is merged or is something in addition needed (e.g. cherry picking like you did for {apm-guide-ref}/aws-lambda-config-options.html) ?

That's correct, a cherry-pick to 8.1 is needed. I'll update.

Comment on lines +13 to +16
+
--
include::supported-technologies.asciidoc[tag=aws-lambda-runtimes]
--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this. FYI I moved the table include into a block element. This allows us to nest it under the accompanying bullet point with a +.

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@AlexanderWert AlexanderWert requested a review from eyalkoren March 31, 2022 13:19
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!! 👏

@bmorelli25
Copy link
Member

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants