-
Notifications
You must be signed in to change notification settings - Fork 327
Improved getting started guide for AWS Lambda #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @bmorelli25, this is the Java Agent counter part to elastic/apm-aws-lambda#158. Corresponding Node.js Agent and Python Agent PRs will follow soon. This PR contains some dependencies on elastic/apm-aws-lambda#158 - is something needed in addition to make those dependencies / includes / links work properly, once elastic/apm-aws-lambda#158 is merged? Thanks! |
1e43add
to
b36e15a
Compare
Before this will pass docs ci, three things need to happen:
|
@elasticmachine, run elasticsearch-ci/docs |
@elasticmachine, run elasticsearch-ci/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview is looking good! Here are some thoughts and comments.
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
The guide assumes that users have an APM Server set up already. We might want to add a step that links to https://www.elastic.co/guide/en/apm/server/current/getting-started-apm-server.html#_hosted_elasticsearch_service so that users that just get started know where to go. We should also add a recommendation that users are recommended to create a cluster on ESS in the same region as their Lambda function. |
@bmorelli25 The build docs are failing now because I added a back link to the Lambda extension |
That's correct, a cherry-pick to 8.1 is needed. I'll update. |
+ | ||
-- | ||
include::supported-technologies.asciidoc[tag=aws-lambda-runtimes] | ||
-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this. FYI I moved the table include into a block element. This allows us to nest it under the accompanying bullet point with a +
.
@elasticmachine, run elasticsearch-ci/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!! 👏
/test |
Depends on: