Restructured docs for AWS Lambda #158

AlexanderWert · 2022-03-24T08:50:45Z

No description provided.

ghost · 2022-03-24T08:58:04Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-03-31T05:57:59.984+0000
Duration: 7 min 28 sec

Test stats 🧪

Test	Results
Failed	0
Passed	240
Skipped	6
Total	246

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

bmorelli25 · 2022-03-24T21:36:47Z

Awesome! A few different things have to happen before this PR can be merged. I'll get started on the following 🚀

1. Copy the original contents of aws-lambda-extension.asciidoc to monitoring-aws-lambda.asciidoc and add it to this repo (in main and 8.1). Duplicate documentation #160
2. Update this line in the apm-server repo to use the new monitoring-aws-lambda.asciidoc file: https://github.com/elastic/apm-server/blame/b951097af2cd622b07b48e1cd77dbd84c1addf54/docs/aws-lambda-extension.asciidoc#L4 (in main and 8.1). docs: update aws-lambda-extension.asciidoc apm-server#7664
4. Merge the changes into this PR. 43ee2fc
5. Let the doc build run to find broken links.
Ah, there aren't any broken links because the agent repos link to current.
6. Add this repo as a dependency to the supported apm-agent-* repos. docs: add apm-aws-lambda as a dependency docs#2404
7. Update agent documentation.
8. Merge and backport this PR.
9. Delete temporary anchor added in fdce935 and update L16. docs: Update anchor link to new AWS Lambda docs apm-server#7769
10. Revert More apm aws dependencies docs#2408.

…docs # Conflicts: # docs/monitoring-aws-lambda.asciidoc

bmorelli25

A few comments. Please don't merge yet.

docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

docs/add-extension/code.asciidoc

docs/images/images.asciidoc

* Restructured docs for AWS Lambda * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * add temp anchor to fix build * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update add-extension-layer.asciidoc * Fixed review comments * Adding missing config options * docs: add env imgs * add images * Added Node.js env-var image Co-authored-by: Emily S <[email protected]> Co-authored-by: bmorelli25 <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Jean-Louis Voiseux <[email protected]>

* Restructured docs for AWS Lambda * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * add temp anchor to fix build * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update add-extension-layer.asciidoc * Fixed review comments * Adding missing config options * docs: add env imgs * add images * Added Node.js env-var image Co-authored-by: Emily S <[email protected]> Co-authored-by: bmorelli25 <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Jean-Louis Voiseux <[email protected]> # Conflicts: # docs/add-extension/add-extension-layer.asciidoc # docs/aws-lambda-extension.asciidoc # docs/lambda-selector/lambda-attributes-selector.asciidoc # docs/monitoring-aws-lambda.asciidoc

* Restructured docs for AWS Lambda (#158) * Restructured docs for AWS Lambda * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * add temp anchor to fix build * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update add-extension-layer.asciidoc * Fixed review comments * Adding missing config options * docs: add env imgs * add images * Added Node.js env-var image Co-authored-by: Emily S <[email protected]> Co-authored-by: bmorelli25 <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Jean-Louis Voiseux <[email protected]> * Created fallback docs if GitHub API request fails. (#173) * docs: fix typo Co-authored-by: Alexander Wert <[email protected]> Co-authored-by: Emily S <[email protected]> Co-authored-by: Jean-Louis Voiseux <[email protected]>

* Restructured docs for AWS Lambda (#158) * Restructured docs for AWS Lambda * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Emily S <[email protected]> * add temp anchor to fix build * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update add-extension-layer.asciidoc * Fixed review comments * Adding missing config options * docs: add env imgs * add images * Added Node.js env-var image Co-authored-by: Emily S <[email protected]> Co-authored-by: bmorelli25 <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Jean-Louis Voiseux <[email protected]> # Conflicts: # docs/add-extension/add-extension-layer.asciidoc # docs/aws-lambda-extension.asciidoc # docs/lambda-selector/lambda-attributes-selector.asciidoc # docs/monitoring-aws-lambda.asciidoc * Created fallback docs if GitHub API request fails. (#173) # Conflicts: # docs/lambda-selector/lambda-attributes-selector.asciidoc * docs: fix typo * Update monitoring-aws-lambda.asciidoc Co-authored-by: Alexander Wert <[email protected]>

Restructured docs for AWS Lambda

7a65b84

AlexanderWert requested review from bmorelli25, estolfo and trentm March 24, 2022 08:50

github-actions bot added the aws-λ-extension AWS Lambda Extension label Mar 24, 2022

estolfo reviewed Mar 24, 2022

View reviewed changes

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

estolfo reviewed Mar 24, 2022

View reviewed changes

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

estolfo reviewed Mar 24, 2022

View reviewed changes

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

estolfo requested changes Mar 24, 2022

View reviewed changes

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

docs/monitoring-aws-lambda.asciidoc Show resolved Hide resolved

AlexanderWert and others added 4 commits March 24, 2022 11:08

Update docs/monitoring-aws-lambda.asciidoc

caad972

Co-authored-by: Emily S <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

1b461f3

Co-authored-by: Emily S <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

06d5c82

Co-authored-by: Emily S <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

8ce87d1

Co-authored-by: Emily S <[email protected]>

This was referenced Mar 24, 2022

Duplicate documentation #160

Merged

docs: update aws-lambda-extension.asciidoc elastic/apm-server#7664

Merged

bmorelli25 added 2 commits March 24, 2022 15:27

Merge branch 'main' of github.com:elastic/apm-aws-lambda into revamp-…

43ee2fc

…docs # Conflicts: # docs/monitoring-aws-lambda.asciidoc

add temp anchor to fix build

fdce935

bmorelli25 reviewed Mar 24, 2022

View reviewed changes

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

docs/monitoring-aws-lambda.asciidoc Outdated Show resolved Hide resolved

AlexanderWert and others added 4 commits March 28, 2022 16:14

Update docs/monitoring-aws-lambda.asciidoc

78ad0c3

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

f98b568

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

85893bb

Co-authored-by: Brandon Morelli <[email protected]>

Update add-extension-layer.asciidoc

52fd605

AlexanderWert mentioned this pull request Mar 29, 2022

Improved getting started guide for AWS Lambda elastic/apm-agent-java#2556

Merged

bmorelli25 reviewed Mar 29, 2022

View reviewed changes

docs/add-extension/code.asciidoc Outdated Show resolved Hide resolved

bmorelli25 mentioned this pull request Mar 29, 2022

[8.1] Cherrypick revamped docs to current #162

Merged

bmorelli25 approved these changes Mar 29, 2022

View reviewed changes

AlexanderWert and others added 2 commits March 30, 2022 09:30

Fixed review comments

e793d57

Adding missing config options

587124e

AlexanderWert mentioned this pull request Mar 30, 2022

Improved lambda getting started docs elastic/apm-agent-python#1511

Merged

bmorelli25 added 2 commits March 30, 2022 14:18

docs: add env imgs

11c66a2

add images

1a497db

bmorelli25 reviewed Mar 30, 2022

View reviewed changes

docs/images/images.asciidoc Show resolved Hide resolved

Added Node.js env-var image

a598093

AlexanderWert marked this pull request as ready for review March 31, 2022 06:02

AlexanderWert requested a review from estolfo March 31, 2022 06:03

estolfo approved these changes Mar 31, 2022

View reviewed changes

jlvoiseux approved these changes Mar 31, 2022

View reviewed changes

bmorelli25 approved these changes Mar 31, 2022

View reviewed changes

AlexanderWert merged commit c6b3fb5 into elastic:main Mar 31, 2022

trentm mentioned this pull request Mar 31, 2022

Improved getting started guide for AWS Lambda elastic/apm-agent-nodejs#2630

Merged

1 task

bmorelli25 mentioned this pull request Apr 1, 2022

Created fallback docs if GitHub API request fails. #173

Merged

bmorelli25 mentioned this pull request Apr 1, 2022

[8.2] Backport AWS Lambda doc updates #175

Merged

bmorelli25 mentioned this pull request Apr 1, 2022

[8.1] Backport AWS Lambda doc updates #176

Merged

This was referenced Apr 1, 2022

docs: Update anchor link to new AWS Lambda docs elastic/apm-server#7769

Merged

Revert "More apm aws dependencies (#2408)" elastic/docs#2414

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Restructured docs for AWS Lambda #158

Restructured docs for AWS Lambda #158

Uh oh!

AlexanderWert commented Mar 24, 2022

Uh oh!

ghost commented Mar 24, 2022 •

edited by ghost

Loading

Build stats

Test stats 🧪

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmorelli25 commented Mar 24, 2022 •

edited

Loading

Uh oh!

bmorelli25 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Restructured docs for AWS Lambda #158

Restructured docs for AWS Lambda #158

Uh oh!

Conversation

AlexanderWert commented Mar 24, 2022

Uh oh!

ghost commented Mar 24, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmorelli25 commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmorelli25 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghost commented Mar 24, 2022 •

edited by ghost

Loading

bmorelli25 commented Mar 24, 2022 •

edited

Loading