Skip to content

Created fallback docs if GitHub API request fails. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2022
Merged

Created fallback docs if GitHub API request fails. #173

merged 1 commit into from
Apr 1, 2022

Conversation

AlexanderWert
Copy link
Member

fixes: #171

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Apr 1, 2022
@AlexanderWert AlexanderWert requested a review from trentm April 1, 2022 07:05
@ghost
Copy link

ghost commented Apr 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-01T07:04:55.798+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 240
Skipped 6
Total 246

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

astorm
astorm approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Does the thing it says it does. When API limits have been reached this is what I see

what-i-see

Approving.

bmorelli25
bmorelli25 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@bmorelli25
Copy link
Member

Merging so I can backport with #158.

trentm
trentm reviewed Apr 1, 2022
View reviewed changes
docs/lambda-selector/lambda-attributes-selector.asciidoc
Comment on lines +130 to +131
<p id="fallback-extension-arn-selector-section">Pick the right ARN from <a target="_bkank" href="RELEASE_LINK">this release table for the APM Lambda Extension Layer</a>.</p>
<p id="fallback-agent-arn-selector-section">In addition, pick the right ARN from <a target="_bkank" href="RELEASE_LINK">this release table for the APM Agent Layer</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p id="fallback-extension-arn-selector-section">Pick the right ARN from <a target="_bkank" href="RELEASE_LINK">this release table for the APM Lambda Extension Layer</a>.</p>
<p id="fallback-agent-arn-selector-section">In addition, pick the right ARN from <a target="_bkank" href="RELEASE_LINK">this release table for the APM Agent Layer</a>.</p>
<p id="fallback-extension-arn-selector-section">Pick the right ARN from <a target="_blank" href="RELEASE_LINK">this release table for the APM Lambda Extension Layer</a>.</p>
<p id="fallback-agent-arn-selector-section">In addition, pick the right ARN from <a target="_blank" href="RELEASE_LINK">this release table for the APM Agent Layer</a>.</p>

Were these intended to be target="_blank"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on main in d0f03e7.

@bmorelli25 bmorelli25 merged commit cdcc365 into elastic:main Apr 1, 2022
@bmorelli25
Copy link
Member

oh wow

@bmorelli25
Copy link
Member

that was awful timing on my part

bmorelli25 pushed a commit to bmorelli25/apm-aws-lambda that referenced this pull request Apr 1, 2022
@AlexanderWert @bmorelli25
Created fallback docs if GitHub API request fails. (elastic#173)
b2da5c5
@bmorelli25 bmorelli25 mentioned this pull request Apr 1, 2022
Merged
bmorelli25 pushed a commit to bmorelli25/apm-aws-lambda that referenced this pull request Apr 1, 2022
@AlexanderWert @bmorelli25
Created fallback docs if GitHub API request fails. (elastic#173)
70f2394 
# Conflicts:
#	docs/lambda-selector/lambda-attributes-selector.asciidoc
@bmorelli25 bmorelli25 mentioned this pull request Apr 1, 2022
Merged
bmorelli25 added a commit that referenced this pull request Apr 1, 2022
@bmorelli25 @AlexanderWert
@estolfo @jlvoiseux
[8.2] Backport AWS Lambda doc updates (#175)
e7794ba 
* Restructured docs for AWS Lambda (#158)

* Restructured docs for AWS Lambda

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* add temp anchor to fix build

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update add-extension-layer.asciidoc

* Fixed review comments

* Adding missing config options

* docs: add env imgs

* add images

* Added Node.js env-var image

Co-authored-by: Emily S <[email protected]>
Co-authored-by: bmorelli25 <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Jean-Louis Voiseux <[email protected]>

* Created fallback docs if GitHub API request fails. (#173)

* docs: fix typo

Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Emily S <[email protected]>
Co-authored-by: Jean-Louis Voiseux <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 1, 2022
@bmorelli25 @AlexanderWert
[8.1] Backport AWS Lambda doc updates (#176)
0316caa 
* Restructured docs for AWS Lambda (#158)

* Restructured docs for AWS Lambda

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Emily S <[email protected]>

* add temp anchor to fix build

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update docs/monitoring-aws-lambda.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

* Update add-extension-layer.asciidoc

* Fixed review comments

* Adding missing config options

* docs: add env imgs

* add images

* Added Node.js env-var image

Co-authored-by: Emily S <[email protected]>
Co-authored-by: bmorelli25 <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Jean-Louis Voiseux <[email protected]>
# Conflicts:
#	docs/add-extension/add-extension-layer.asciidoc
#	docs/aws-lambda-extension.asciidoc
#	docs/lambda-selector/lambda-attributes-selector.asciidoc
#	docs/monitoring-aws-lambda.asciidoc

* Created fallback docs if GitHub API request fails. (#173)

# Conflicts:
#	docs/lambda-selector/lambda-attributes-selector.asciidoc

* docs: fix typo

* Update monitoring-aws-lambda.asciidoc

Co-authored-by: Alexander Wert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

+2 more reviewers

@trentm trentm trentm left review comments

@astorm astorm astorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

improve addArnGenerator() templating in APM Lambda docs to cope with failed api.github.com request

4 participants

@AlexanderWert @bmorelli25 @trentm @astorm