docs: add apm-aws-lambda as a dependency
#2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtback I might need to pick your brain on this one. As the summary says, we're trying to add one repository as a dependency of the other three. The difficult part is that all four repositories are versioned differently. |
gtback
reviewed
Mar 28, 2022
There was a problem hiding this comment.
The difficult part is that all four repositories are versioned differently.
This is exactly what map_branches is for. The *mapMasterToMain and *mapMainToMaster are just shortcuts for when that's the only mismatch in branch names (and since all four of the repos use main, you won't need either of those).
Co-authored-by: Greg Back <[email protected]>
gtback
approved these changes
Mar 28, 2022
|
Build failed for the same reason the main build is failing. If we re-run this tomorrow, it will hopefully pass. |
|
@elasticmachine, run elasticsearch-ci/docs rebuild |
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the docs directory in
elastic/apm-aws-lambdaas a dependency to the following repos:elastic/apm-agent-javaelastic/apm-agent-nodejselastic/apm-agent-pythonFor https://github.com/elastic/observability-docs/issues/1707.