Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Apr 4, 2022

What does this pull request do?

Avoid failing the packer_cache process.

Why

#1505 broke the script, but the packer_cache should work on best-effort, so if possible then cache the images, otherwise do not fail.

Then the packer cache image generation can move on with the next packer_cache project. Otherwise, we won't be using latest cache images

@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Apr 4, 2022
@v1v v1v requested review from a team April 4, 2022 11:44
@v1v v1v self-assigned this Apr 4, 2022
@ghost
Copy link

ghost commented Apr 4, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-04T11:45:09.927+0000

  • Duration: 18 min 22 sec

Test stats 🧪

Test Results
Failed 1
Passed 4819
Skipped 3208
Total 8028

Test errors 1

Expand to view the tests failures

Initializing / Test / Python-python-3.10-0 / test_get[/greet/sanic-GET /greet/<name:string>-0-custom_context1] – tests.contrib.sanic.sanic_tests
    Expand to view the error details

     AssertionError: assert 'GET /greet/sanic' == 'GET /greet/<name:string>'
      - GET /greet/<name:string>
      + GET /greet/sanic 
    

    Expand to view the stacktrace

     url = '/greet/sanic', transaction_name = 'GET /greet/<name:string>'
    span_count = 0, custom_context = {'name': 'sanic'}
    sanic_elastic_app = <function sanic_elastic_app.<locals>._generate at 0x7f0ab386ef80>
    elasticapm_client = <tests.fixtures.TempStoreClient object at 0x7f0ab3ce6ec0>
    
        @pytest.mark.parametrize(
            "url, transaction_name, span_count, custom_context",
            [("/", "GET /", 1, {}), ("/greet/sanic", "GET /greet/<name:string>", 0, {"name": "sanic"})],
        )
        def test_get(url, transaction_name, span_count, custom_context, sanic_elastic_app, elasticapm_client):
            sanic_app, apm = next(sanic_elastic_app(elastic_client=elasticapm_client))
            source_request, response = sanic_app.test_client.get(
                url,
                headers={
                    constants.TRACEPARENT_HEADER_NAME: "00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-03",
                    constants.TRACESTATE_HEADER_NAME: "foo=bar,bar=baz",
                    "REMOTE_ADDR": "127.0.0.1",
                },
            )  # type: sanic.response.HttpResponse
        
            assert len(elasticapm_client.events[constants.TRANSACTION]) == 1
            transaction = elasticapm_client.events[constants.TRANSACTION][0]
            spans = elasticapm_client.spans_for_transaction(transaction)
            assert len(spans) == span_count
            if span_count > 0:
                span = spans[0]
                assert span["name"] == "test"
                assert transaction["span_count"]["started"] == span_count
        
            for field, value in {
                "name": transaction_name,
                "result": "HTTP 2xx",
                "outcome": "success",
                "type": "request",
            }.items():
    >           assert transaction[field] == value
    E           AssertionError: assert 'GET /greet/sanic' == 'GET /greet/<name:string>'
    E             - GET /greet/<name:string>
    E             + GET /greet/sanic
    
    tests/contrib/sanic/sanic_tests.py:72: AssertionError 
    

Steps errors 4

Expand to view the steps failures

Shell Script
  • Took 0 min 20 sec . View more details here
  • Description: ./tests/scripts/docker/run_tests.sh python-3.10 sanic-newest
Shell Script
  • Took 0 min 20 sec . View more details here
  • Description: ./tests/scripts/docker/run_tests.sh python-3.10 sanic-newest
Archive the artifacts
  • Took 0 min 0 sec . View more details here
  • Description: [2022-04-04T12:03:28.764Z] Archiving artifacts Python-python-3.10-sanic-newest tests failed : hudso
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Python-python-3.10-sanic-newest tests failed : hudson.AbortException: script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / Test / Python-python-3.10-0 / test_get[/greet/sanic-GET /greet/<name:string>-0-custom_context1] – tests.contrib.sanic.sanic_tests

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
Copy link
Member Author

v1v commented Apr 4, 2022

Unrelated test failures, this particular change is not tested in the CI directly but in another process. We are safe to merge it

@v1v v1v merged commit aeb2d01 into elastic:main Apr 4, 2022
basepi added a commit that referenced this pull request Apr 6, 2022
* Improved lambda getting started docs (#1511)

* Improve lambda getting started docs

* fixed labels in configure-lambda-widget.asciidoc

* match java prereq language

* remove img and include from another repo

* fixed heading level of step 3

Co-authored-by: bmorelli25 <[email protected]>

* ci: packer_cache never fail (#1516)

* Fix sanic tests (#1518)

Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: bmorelli25 <[email protected]>
Co-authored-by: Victor Martinez <[email protected]>
@v1v v1v mentioned this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python automation Team:Automation Label for the Observability productivity team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants