Fix sanic tests #1518
Merged
Fix sanic tests #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
beniwohli
approved these changes
Apr 6, 2022
basepi
added a commit
that referenced
this pull request
Apr 6, 2022
* Improved lambda getting started docs (#1511) * Improve lambda getting started docs * fixed labels in configure-lambda-widget.asciidoc * match java prereq language * remove img and include from another repo * fixed heading level of step 3 Co-authored-by: bmorelli25 <[email protected]> * ci: packer_cache never fail (#1516) * Fix sanic tests (#1518) Co-authored-by: Alexander Wert <[email protected]> Co-authored-by: bmorelli25 <[email protected]> Co-authored-by: Victor Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
See sanic-org/sanic#2423 for some context.
Our Sanic tests were failing due to not being able to get the route from one of the requests.
It took me awhile to track down the issue, but it turns out the router stopped accepting
<name:string>and wants<name:str>instead. This was not listed as a breaking change in their release notes, so I recommended they add it.Related issues
Closes #1515