Adding TOC and index to readme [MTT-4617] #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBellomo
added
0-URGENT
SamuelBellomo
requested review from
LPLafontaineB,
MorwennaG,
chrispope,
fernando-cortez,
jilfranco-unity and
pdeschain
SamuelBellomo
added
the
0-URGENT
Contributor
Author
|
Initial draft, links are not made yet. Let me know what you think of this format before I invest more time in this |
LPLafontaineB
previously approved these changes
Sep 23, 2022
chrispope
previously approved these changes
Sep 26, 2022
SamuelBellomo
dismissed stale reviews from chrispope and LPLafontaineB
via
8845bf6
Contributor
fernando-cortez
left a comment
fernando-cortez
left a comment
There was a problem hiding this comment.
Lots of nitpicks, but looking real good!
Co-authored-by: Fernando Cortez <[email protected]>
…-Technologies/com.unity.multiplayer.samples.coop into sam/feat/better-indexing-in-readme * 'sam/feat/better-indexing-in-readme' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop: removing test and fixing a link test2 test, should be reverted
LPLafontaineB
previously approved these changes
Sep 28, 2022
pdeschain
previously approved these changes
Sep 28, 2022
Contributor
pdeschain
left a comment
pdeschain
left a comment
There was a problem hiding this comment.
I like it very much. An index to important classes is really cool.
SamuelBellomo
dismissed stale reviews from pdeschain and LPLafontaineB
via
bb12324
…-Technologies/com.unity.multiplayer.samples.coop into sam/feat/better-indexing-in-readme * 'sam/feat/better-indexing-in-readme' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop: Adding more player related entries
fernando-cortez
approved these changes
Sep 29, 2022
fernando-cortez
added
2-One More Review
LPLafontaineB
approved these changes
Sep 29, 2022
LPLafontaineB
added
3-Good to Merge
and removed
2-One More Review
SamuelBellomo
commented
Oct 3, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Oct 13, 2022
* develop: (60 commits) fix: removing FindObjectOfType for a serialized reference (#754) fix: can click through loading screen [MTT-4753] (#760) Update CHANGELOG.md (#765) feat: Architecture.md update (MTT-2637) (#763) Update README.md (#759) Updating utilities package for release (#764) Version bumps (#761) Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758) adding components refs to index (#757) Adding link to feedback form at the top (#756) chore: adding details to changelog (#746) Updating readme with Typeform for feedback (#755) made arrow trails smaller (#750) Fixed up some layer settings on some archer VFX so that they show up properly! (#739) fix: lobby UI unblocking before it should [MTT-4579] (#748) feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612) Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753) fix: Moving utp to component instead of child GameObject (#752) Adding TOC and index to readme [MTT-4617] (#736) Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751) ... # Conflicts: # Assets/Prefabs/NetworkingManager.prefab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Learnings are not super easy to find. Readme is the landing page for folks. This PR aims to organize things a bit more by adding an encyclopaedia-style index of learnings that'd link to specific spots in the repo.
Adding TOC as well, in the same vein.
Issue Number(s)
MTT-4617
Contribution checklist