Skip to content

Conversation

@jilfranco-unity
Copy link
Contributor

Description

A quick fix on the layers for some archer VFX so that they're not hidden completely on certain quality settings!

Issue Number(s)

N/A

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [N/A] JIRA ticket ID is in the PR title or at least one commit message
  • [N/A] Include the ticket ID number within the body message of the PR to create a hyperlink

@jilfranco-unity jilfranco-unity added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 23, 2022
@SamuelBellomo SamuelBellomo requested review from fernando-cortez and pdeschain and removed request for SamuelBellomo September 23, 2022 18:40
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Sep 26, 2022
@fernando-cortez fernando-cortez added 2-Reviewed with Comments PR requires owner's attention and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 26, 2022
# Conflicts:
#	Assets/VFX/Prefabs/Archer/fx_ArrowGraphics.prefab
#	Assets/VFX/Prefabs/Archer/fx_ChargedArrow1Graphics.prefab
#	Assets/VFX/Prefabs/Archer/fx_ChargedArrow2Graphics.prefab
#	Assets/VFX/Prefabs/Archer/fx_ChargedArrow3Graphics.prefab
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 2-Reviewed with Comments PR requires owner's attention labels Sep 27, 2022
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Sep 29, 2022
@SamuelBellomo SamuelBellomo enabled auto-merge (squash) September 29, 2022 21:31
@SamuelBellomo SamuelBellomo merged commit 4466d02 into develop Sep 29, 2022
@SamuelBellomo SamuelBellomo deleted the fix/hidden-archer-VFX branch September 29, 2022 22:08
SamuelBellomo added a commit that referenced this pull request Oct 13, 2022
* develop: (60 commits)
  fix: removing FindObjectOfType for a serialized reference (#754)
  fix: can click through loading screen [MTT-4753] (#760)
  Update CHANGELOG.md (#765)
  feat: Architecture.md update (MTT-2637) (#763)
  Update README.md (#759)
  Updating utilities package for release (#764)
  Version bumps (#761)
  Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758)
  adding components refs to index (#757)
  Adding link to feedback form at the top (#756)
  chore: adding details to changelog (#746)
  Updating readme with Typeform for feedback (#755)
  made arrow trails smaller (#750)
  Fixed up some layer settings on some archer VFX so that they show up properly! (#739)
  fix: lobby UI unblocking before it should [MTT-4579] (#748)
  feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612)
  Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753)
  fix: Moving utp to component instead of child GameObject (#752)
  Adding TOC and index to readme [MTT-4617] (#736)
  Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751)
  ...

# Conflicts:
#	Assets/Prefabs/NetworkingManager.prefab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants