fix: Moving utp to component instead of child GameObject #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBellomo
added
0-URGENT
LPLafontaineB
approved these changes
Sep 29, 2022
SamuelBellomo
added
2-One More Review
Contributor
fernando-cortez
left a comment
fernando-cortez
left a comment
There was a problem hiding this comment.
Startup scene shouldn't need to be changed. Any particular changes inside of there?
Contributor
Author
@fernando-cortez This is a URP script:
|
fernando-cortez
approved these changes
Sep 29, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-Reviewed with Comments
SamuelBellomo
deleted the
sam/fix/move-UTP-to-single-component-instead-of-go
branch
SamuelBellomo
added a commit
that referenced
this pull request
Oct 13, 2022
* develop: (60 commits) fix: removing FindObjectOfType for a serialized reference (#754) fix: can click through loading screen [MTT-4753] (#760) Update CHANGELOG.md (#765) feat: Architecture.md update (MTT-2637) (#763) Update README.md (#759) Updating utilities package for release (#764) Version bumps (#761) Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758) adding components refs to index (#757) Adding link to feedback form at the top (#756) chore: adding details to changelog (#746) Updating readme with Typeform for feedback (#755) made arrow trails smaller (#750) Fixed up some layer settings on some archer VFX so that they show up properly! (#739) fix: lobby UI unblocking before it should [MTT-4579] (#748) feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612) Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753) fix: Moving utp to component instead of child GameObject (#752) Adding TOC and index to readme [MTT-4617] (#736) Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751) ... # Conflicts: # Assets/Prefabs/NetworkingManager.prefab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a child GO for historical reasons that have no more reasons to be. Since now our only transport is UTP, let's make this more self contained.
UTP is now a component on NetworkManager directly
Issue Number(s)
Contribution checklist