Skip to content

Conversation

@LPLafontaineB
Copy link
Contributor

Description

This PR adds more details to changelog entries for the next release.

Issue Number(s)

None

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Sep 29, 2022
fernando-cortez
fernando-cortez previously approved these changes Oct 3, 2022
@fernando-cortez fernando-cortez added the 2-One More Review One review in, one to go label Oct 3, 2022
Forgot to do changelog for boss room in previous hotfix, just did a changelog for the package. Fixing this.
@SamuelBellomo SamuelBellomo marked this pull request as ready for review October 4, 2022 14:10
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did Phil's PRs. I believe that was it. I just put it as ready for review

@SamuelBellomo
Copy link
Contributor

@chrispope let us know if you'd like more details. Jil is currently looking at producing gifs and images that'll go in the github release section, this PR is just for the details part.

@chrispope
Copy link
Collaborator

chrispope commented Oct 4, 2022

@chrispope let us know if you'd like more details. Jil is currently looking at producing gifs and images that'll go in the github release section, this PR is just for the details part.

Descriptions are much improved ❤️ I will add a proper review when it is ready.

Copy link
Collaborator

@chrispope chrispope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamuelBellomo SamuelBellomo enabled auto-merge (squash) October 4, 2022 17:22
@SamuelBellomo SamuelBellomo disabled auto-merge October 4, 2022 17:23
@SamuelBellomo SamuelBellomo merged commit 18f8248 into develop Oct 4, 2022
@SamuelBellomo SamuelBellomo deleted the chore/adding-details-to-changelog branch October 4, 2022 17:23
SamuelBellomo added a commit that referenced this pull request Oct 13, 2022
* develop: (60 commits)
  fix: removing FindObjectOfType for a serialized reference (#754)
  fix: can click through loading screen [MTT-4753] (#760)
  Update CHANGELOG.md (#765)
  feat: Architecture.md update (MTT-2637) (#763)
  Update README.md (#759)
  Updating utilities package for release (#764)
  Version bumps (#761)
  Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758)
  adding components refs to index (#757)
  Adding link to feedback form at the top (#756)
  chore: adding details to changelog (#746)
  Updating readme with Typeform for feedback (#755)
  made arrow trails smaller (#750)
  Fixed up some layer settings on some archer VFX so that they show up properly! (#739)
  fix: lobby UI unblocking before it should [MTT-4579] (#748)
  feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612)
  Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753)
  fix: Moving utp to component instead of child GameObject (#752)
  Adding TOC and index to readme [MTT-4617] (#736)
  Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751)
  ...

# Conflicts:
#	Assets/Prefabs/NetworkingManager.prefab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 2-One More Review One review in, one to go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants