feat: PubSub improvement: ISubscriber unsub [MTT-2765] #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeschain
added
2-Easy
Contributor
|
With this, I would have expected to see changes in callsites of ISubscriber no? What kinds of improvements can we do with this? |
Contributor
|
Keep Dispose for bundled dispose, for single dispose, can use symmetrical unsubscribe. |
SamuelBellomo
added
2-Reviewed with Comments
Contributor
|
Adding this for all PRs that have been opened since this new flow has been added. Please add your changelog here project changelog file and/or package changelog file |
pdeschain
added
1-Needs Review
fernando-cortez
previously approved these changes
Sep 7, 2022
fernando-cortez
added
2-Reviewed with Comments
SamuelBellomo
previously approved these changes
Sep 9, 2022
SamuelBellomo
added
0-URGENT
Co-authored-by: Fernando Cortez <[email protected]>
pdeschain
dismissed stale reviews from SamuelBellomo and fernando-cortez
via
047dac0
# Conflicts: # Assets/Scripts/Gameplay/GameState/ServerBossRoomState.cs # CHANGELOG.md
… it with conditional
SamuelBellomo
previously approved these changes
Sep 29, 2022
LPLafontaineB
previously approved these changes
Sep 29, 2022
LPLafontaineB
added
3-Good to Merge
and removed
2-Reviewed with Comments
fernando-cortez
previously approved these changes
Sep 29, 2022
fernando-cortez
added
2-Reviewed with Comments
pdeschain
dismissed stale reviews from fernando-cortez, LPLafontaineB, and SamuelBellomo
via
83d5312
pdeschain
requested review from
LPLafontaineB,
SamuelBellomo and
fernando-cortez
fernando-cortez
approved these changes
Sep 29, 2022
LPLafontaineB
approved these changes
Sep 29, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Oct 13, 2022
* develop: (60 commits) fix: removing FindObjectOfType for a serialized reference (#754) fix: can click through loading screen [MTT-4753] (#760) Update CHANGELOG.md (#765) feat: Architecture.md update (MTT-2637) (#763) Update README.md (#759) Updating utilities package for release (#764) Version bumps (#761) Updating broken PR links (shouldn't be linked to jira) and changelog fixes (#758) adding components refs to index (#757) Adding link to feedback form at the top (#756) chore: adding details to changelog (#746) Updating readme with Typeform for feedback (#755) made arrow trails smaller (#750) Fixed up some layer settings on some archer VFX so that they show up properly! (#739) fix: lobby UI unblocking before it should [MTT-4579] (#748) feat: PubSub improvement: ISubscriber unsub [MTT-2765] (#612) Fix: Reduction of SSAO Cost (Especially on Mac) [MTT-4558] (#753) fix: Moving utp to component instead of child GameObject (#752) Adding TOC and index to readme [MTT-4617] (#736) Feat: Char Portrait Mouse Hover Feedback [MTT-4754] (#751) ... # Conflicts: # Assets/Prefabs/NetworkingManager.prefab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turned out to be a one-liner change that would allow us to also Usubscribe from ISubscribers.
Issue Number(s)
MTT-2765
Contribution checklist