Skip to content

fix: adding RTT graph to RNSM [MTT-4788] #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2022
Merged

fix: adding RTT graph to RNSM [MTT-4788] #747

merged 3 commits into from
Sep 28, 2022

Conversation

@SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Sep 28, 2022 •
edited
Loading

Description

Multiple times during playtests we've wished for RTT presented as a graph instead of as a single value.
Wish no more

Issue Number(s)

MTT-4788

Contribution checklist

  • n/a Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@SamuelBellomo SamuelBellomo added 0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 28, 2022
@SamuelBellomo SamuelBellomo marked this pull request as ready for review September 28, 2022 17:55
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 28, 2022
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Sep 28, 2022
@SamuelBellomo SamuelBellomo merged commit 7355957 into develop Sep 28, 2022
@SamuelBellomo SamuelBellomo deleted the sam/fix/switching-RTT-to-graph-instead-of-single-value branch September 28, 2022 20:59
SamuelBellomo added a commit that referenced this pull request Sep 29, 2022
@SamuelBellomo
Merge branch 'develop' into sam/feat/better-indexing-in-readme
e35d9df 
* develop:
  Fix: Changed Default Quality Setting to Medium (#749)
  fix: adding RTT graph to RNSM [MTT-4788] (#747)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdeschain pdeschain Awaiting requested review from pdeschain

@ashwinimurt ashwinimurt Awaiting requested review from ashwinimurt

2 more reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SamuelBellomo @fernando-cortez @LPLafontaineB