Read term_common_params from the snapshot #1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foriequal0
changed the title
foriequal0
force-pushed
the
feature/term_common_params
branch
from
d353f06 to
c474f2d
Compare
4 tasks
foriequal0
changed the title
majecty
requested changes
Nov 26, 2019
remagpie
reviewed
Nov 26, 2019
remagpie
requested changes
Nov 26, 2019
remagpie
reviewed
Nov 26, 2019
remagpie
requested changes
Nov 26, 2019
remagpie
reviewed
Nov 26, 2019
foriequal0
force-pushed
the
feature/term_common_params
branch
from
e103418 to
cb64747
Compare
remagpie
approved these changes
Nov 27, 2019
majecty
approved these changes
Nov 27, 2019
majecty
approved these changes
Nov 27, 2019
foriequal0
force-pushed
the
feature/term_common_params
branch
4 times, most recently
from
40666c6 to
0584ff0
Compare
sgkim126
reviewed
Nov 27, 2019
sgkim126
reviewed
Nov 27, 2019
| self.term_params.as_ref() | ||
| } | ||
|
|
||
| pub fn snapshot_term_params(&mut self) { |
There was a problem hiding this comment.
I think there is a more proper name than snapshot_term_params.
There was a problem hiding this comment.
I know snapshot is a little bit confusing. It collides with the name of the snapshot sync feature and it is awkward to use it as a verb to me, but I can't think of a better one. Can you suggest a good one? How about freeze_?
There was a problem hiding this comment.
Would you mind if we change the name later? @remagpie is dependant on this PR.
There was a problem hiding this comment.
Changing the name is not a big deal in my work. You can change it now if you want.
sgkim126
reviewed
Nov 27, 2019
foriequal0
force-pushed
the
feature/term_common_params
branch
from
acd786a to
60a235b
Compare
remagpie
reviewed
Nov 28, 2019
Merged
`term_params` should be snapshot every `on_term_close`
foriequal0
force-pushed
the
feature/term_common_params
branch
from
60a235b to
cd9a669
Compare
sgkim126
approved these changes
Nov 28, 2019
This was referenced Dec 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1893