fixup! Add term_params to Metadata

Author: foriequal0

state/src/item/metadata.rs

@@ -146,24 +146,18 @@ impl Encodable for Metadata {
         let params_changed = self.seq != 0;
         let term_params_exist = self.term_params.is_some();
 
-        let mut len = INITIAL_LEN;
-        // Clippy complain how `let mut len` statements are constructed,
-        // but their alternative is uglier
-        #[allow(clippy::useless_let_if_seq)]
-        {
-            if term_changed {
-                len = TERM_LEN;
-            }
-            if params_changed {
-                len = PARAMS_LEN;
-            }
-            if term_params_exist {
-                if !params_changed {
-                    panic!("Term params only can be changed if params changed");
-                }
-                len = TERM_PARAMS_LEN;
+        let len = if term_params_exist {
+            if !params_changed {
+                panic!("Term params only can be changed if params changed");
             }
-        }
+            TERM_PARAMS_LEN
+        } else if params_changed {
+            PARAMS_LEN
+        } else if term_changed {
+            TERM_LEN
+        } else {
+            INITIAL_LEN
+        };
 
         s.begin_list(len)
             .append(&PREFIX)