Skip to content

Conversation

@foriequal0
Copy link
Contributor

No description provided.

Copy link
Contributor

@remagpie remagpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

era should be monotonically increasing.
I think we need a verification logic for ChangeCommonParams checking it.

@sgkim126
Copy link
Contributor

I cannot find the behavior change in 59e1696.
I think the commit title should be Extract a function to verify a new CommonParams compare to the current params

@foriequal0
Copy link
Contributor Author

Tests are quite flaky. They are fine on my machine.

@foriequal0 foriequal0 merged commit f83de3d into CodeChain-io:era Nov 26, 2019
@foriequal0 foriequal0 deleted the feature/era branch November 26, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants