Skip to content

[WIP] Introduce Era #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

[WIP] Introduce Era #1910

wants to merge 20 commits into from

Conversation

@foriequal0
Copy link
Contributor

@foriequal0 foriequal0 commented Dec 4, 2019 •
edited
Loading

Related issue: #1884

remagpie and others added 20 commits November 26, 2019 13:54
@remagpie
Remove redundant variable in tendermint/engine
36ce74e
@remagpie
Change block_number_if_term_changed to is_term_changed
cbfc7bc 
`block_number_if_term_changed` was returning the current block
number if the term changed, which could be calculated in the outer
scope.
@remagpie
Refactor is_term_changed check in on_close_block
414007e
@remagpie
Refactor on_term_close call in on_close_block
c36e741
@remagpie
Remove unnecessary mutable borrow
dc4517b
@foriequal0
Add era to CommonParams
902265a
@foriequal0
Extract a function to verify a new CommonParams compare to the curren…
114b058 
…t params
@foriequal0
Make era nondecreasing
f83de3d
@remagpie @foriequal0
Include ConsensusClient in Solo engine
d1e1c7e
@remagpie @foriequal0
Add a helper function for obtaining client
f596169
@remagpie @foriequal0
Derive parent block information inside consensus engine
bb0d968
@foriequal0
Refactor term_common_params method
a85b60a
@foriequal0
Add term_params to Metadata
4634de4 
`term_params` should be snapshot every `on_term_close`
@foriequal0
Snapshot term_metadata on every term close for the era > 0
09af46a
@foriequal0
Read term_params from the snapshot
237b7f4
@foriequal0
Add era support to e2e dynval test
6519162
@foriequal0
Add basic era tests
e4377cf
@remagpie
Introduce on_open_block
95c1562 
`on_open_block` is called when the block is created, before
processing any transactions included in the block.
@remagpie
Precalculate the fee in era=1
be7dbee
@remagpie
Update the era with the value in current block's state
b172e19 
At `on_term_close`, the term_common_params is not updated to the
new parameters yet. But the parameters in the current block's
state is updated, so we should get the `era` from there.
@foriequal0 foriequal0 added the do-not-merge Do not merge (for mergify.io) label Dec 4, 2019
@foriequal0 foriequal0 mentioned this pull request Dec 4, 2019
Closed
@foriequal0
Copy link
Contributor Author

foriequal0 commented Dec 5, 2019 •
edited
Loading

I'll close this. I'll make two PRs, refactors and introduce the era.

Refactor to introduce the snapshot sync #1916
Introduce Era #1917

@foriequal0 foriequal0 closed this Dec 5, 2019
@foriequal0 foriequal0 mentioned this pull request Dec 5, 2019
Merged
@foriequal0 foriequal0 deleted the era branch December 5, 2019 09:17
@foriequal0 foriequal0 mentioned this pull request Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majecty majecty Awaiting requested review from majecty

@sgkim126 sgkim126 Awaiting requested review from sgkim126

@HoOngEe HoOngEe Awaiting requested review from HoOngEe

Assignees

No one assigned

Labels

do-not-merge Do not merge (for mergify.io) experimental

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@foriequal0 @remagpie