Refactor on_close_block, take #2
#1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majecty
approved these changes
Nov 26, 2019
sgkim126
approved these changes
Nov 26, 2019
foriequal0
requested changes
Nov 26, 2019
| block: &mut ExecutedBlock, | ||
| parent_header: &Header, | ||
| parent_common_params: &CommonParams, | ||
| term_common_params: Option<&CommonParams>, |
There was a problem hiding this comment.
Can you remove this parameter too?
There was a problem hiding this comment.
I tried to do that, and I thought it'd be a bit complex for now.
How about removing this after #1895 is merged?
remagpie
force-pushed
the
refactor-on-close
branch
from
d840fac to
8067035
Compare
foriequal0
approved these changes
Nov 27, 2019
This was referenced Dec 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.