Make CommonParams be verified with the current CommonParams

Author: foriequal0

core/src/consensus/stake/actions.rs

@@ -105,15 +105,7 @@ impl Action {
                 params,
                 signatures,
             } => {
-                let current_network_id = current_params.network_id();
-                let transaction_network_id = params.network_id();
-                if current_network_id != transaction_network_id {
-                    return Err(SyntaxError::InvalidCustomAction(format!(
-                        "The current network id is {} but the transaction tries to change the network id to {}",
-                        current_network_id, transaction_network_id
-                    )))
-                }
-                params.verify().map_err(SyntaxError::InvalidCustomAction)?;
+                params.verify_change(current_params).map_err(SyntaxError::InvalidCustomAction)?;
                 let action = Action::ChangeParams {
                     metadata_seq: *metadata_seq,
                     params: params.clone(),

types/src/common_params.rs

@@ -220,6 +220,19 @@ impl CommonParams {
         }
         Ok(())
     }
+
+    pub fn verify_change(&self, current_params: &Self) -> Result<(), String> {
+        self.verify()?;
+        let current_network_id = current_params.network_id();
+        let transaction_network_id = self.network_id();
+        if current_network_id != transaction_network_id {
+            return Err(format!(
+                "The current network id is {} but the transaction tries to change the network id to {}",
+                current_network_id, transaction_network_id
+            ))
+        }
+
+    }
 }
 
 const DEFAULT_PARAMS_SIZE: usize = 23;