Read term_common_params from the state #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majecty
previously approved these changes
Dec 20, 2019
remagpie
force-pushed
the
term-common-params
branch
from
65f9719 to
47a0ca2
Compare
sgkim126
reviewed
Dec 21, 2019
sgkim126
reviewed
Dec 22, 2019
remagpie
force-pushed
the
term-common-params
branch
2 times, most recently
from
d57dce0 to
df86ac4
Compare
remagpie
changed the title
`term_params` should be snapshot every `on_term_close`
remagpie
force-pushed
the
term-common-params
branch
from
df86ac4 to
1a6960a
Compare
majecty
approved these changes
Dec 24, 2019
sgkim126
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from CodeChain-io/codechain#1895
Some parts are revised to match the foundry's situation.