Issue34timestamp #36
Closed
Issue34timestamp #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conn.query("SELECT * FROM timestamptest;", onSuccess(rs2 -> { | ||
| assertNotNull(rs2); | ||
| assertNotNull(rs2.getResults()); | ||
| conn.execute("DROP TABLE timestamptest", onSuccess(rs3 -> { |
Contributor
There was a problem hiding this comment.
Generally, I'd recommend dropping the table before the test and not after it. You can then check the database if anything strange happened after running the test.
Contributor
|
Great, thanks for this PR, I will check it out locally and add the proposed changes to the code! |
Contributor
|
👍 |
Contributor
|
Please have a look at #37 which includes these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eclipse CLA is signed.
PR including the quickfix with testcases for issue #34.