Skip to content

Conversation

@Narigo
Copy link
Contributor

@Narigo Narigo commented Feb 5, 2016

This PR adds configuration options for charset and query timeout.

I have added the option for connection timeout, but it won't do anything yet, as the underlying driver doesn't seem to support it yet (see mauricio/postgresql-async#6). There is an ignored / skipped test for it.

@Narigo Narigo force-pushed the add-config-options branch 2 times, most recently from 54be135 to 4b36249 Compare February 5, 2016 18:46
@Narigo Narigo force-pushed the add-config-options branch from 4b36249 to 61a845c Compare February 5, 2016 18:47
@Narigo
Copy link
Contributor Author

Narigo commented Feb 7, 2016

@vietj could you review this please? I could use the AbstractTestBase class defined here to make #36 even more consistent to the other tests ;)

Thanks!

@vietj
Copy link
Contributor

vietj commented Feb 7, 2016

👍

Narigo added a commit that referenced this pull request Feb 8, 2016
Add configuration options for charset and timeout
@Narigo Narigo merged commit 61ec4c5 into master Feb 8, 2016
@Narigo Narigo removed the to review label Feb 8, 2016
@Narigo Narigo deleted the add-config-options branch February 8, 2016 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants