Fix date time and a bit refactoring #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne' - regarding issue #34
* Removes VertxTestBase dependency in PostgreSQL test * Adds better error handling * Make queryTypeTimestampWith(out)TimezoneTest consistent to other tests Signed-off-by: Joern Bernhardt <[email protected]>
Signed-off-by: Joern Bernhardt <[email protected]>
Contributor
|
Did the changes you suggested but you were faster :). |
Member
|
Looks good to me. @pmlopes can you have a look to the date stuff ? (you're the date expert ;-)). |
| conn.query("SELECT * FROM test_table;", onSuccess(context, timestampSelect -> { | ||
| context.assertNotNull(timestampSelect); | ||
| context.assertNotNull(timestampSelect.getResults()); | ||
| context.assertTrue(timestampSelect.getResults().get(0).getString(0).matches("\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}\\.\\d{3}(Z|[+-]\\d{2}:\\d{2})")); |
Contributor
Author
There was a problem hiding this comment.
@pmlopes this would be the check I mentioned over there: 14bb98b#commitcomment-16058891
Member
|
👍 |
pmlopes
added a commit
that referenced
this pull request
Feb 15, 2016
Fix date time and a bit refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the patch @augeneinblick !
I've added a regexp to check that we look at a time with or without timezones and did some refactoring. Now almost all tests use vertx-unit instead of
VertxTestBase- onlyRefCountTestis still usingVertxTestBase.There is also an additional
try/catchblock that handles unexpected types coming from the server.