Fix date time and a bit refactoring #37
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,64 +18,83 @@ | |
|
|
||
| import io.vertx.core.json.JsonArray; | ||
| import io.vertx.core.json.JsonObject; | ||
| import io.vertx.ext.sql.ResultSet; | ||
| import io.vertx.ext.unit.Async; | ||
| import io.vertx.ext.unit.TestContext; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * @author <a href="http://www.campudus.com">Joern Bernhardt</a>. | ||
| */ | ||
| public class PostgreSQLTest extends AbstractTestBase { | ||
|
|
||
| final JsonObject config = new JsonObject() | ||
| .put("host", System.getProperty("db.host", "localhost")); | ||
|
|
||
| @Before | ||
| public void init() { | ||
| client = PostgreSQLClient.createNonShared(vertx, config); | ||
| } | ||
|
|
||
| @Test | ||
| public void someTest(TestContext context) throws Exception { | ||
| Async async = context.async(); | ||
| client.getConnection(connAr -> { | ||
| ensureSuccess(context, connAr); | ||
| conn = connAr.result(); | ||
| conn.query("SELECT 1 AS something", resultSetAr -> { | ||
| ensureSuccess(context, resultSetAr); | ||
| ResultSet resultSet = resultSetAr.result(); | ||
| context.assertNotNull(resultSet); | ||
| context.assertNotNull(resultSet.getColumnNames()); | ||
| context.assertNotNull(resultSet.getResults()); | ||
| context.assertEquals(new JsonArray().add(1), resultSet.getResults().get(0)); | ||
| async.complete(); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void queryTypeTimestampWithTimezoneTest(TestContext context) throws Exception { | ||
| Async async = context.async(); | ||
| client.getConnection(connAr -> { | ||
| ensureSuccess(context, connAr); | ||
| conn = connAr.result(); | ||
| conn.execute("DROP TABLE IF EXISTS test_table", onSuccess(context, dropped -> { | ||
| conn.execute("CREATE TABLE IF NOT EXISTS test_table (ts timestamp with time zone)", onSuccess(context, created -> { | ||
| conn.execute("INSERT INTO test_table (ts) VALUES (now())", onSuccess(context, inserted -> { | ||
| conn.query("SELECT * FROM test_table;", onSuccess(context, timestampSelect -> { | ||
| context.assertNotNull(timestampSelect); | ||
| context.assertNotNull(timestampSelect.getResults()); | ||
| context.assertTrue(timestampSelect.getResults().get(0).getString(0).matches("\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}\\.\\d{3}(Z|[+-]\\d{2}:\\d{2})")); | ||
| async.complete(); | ||
| })); | ||
| })); | ||
| })); | ||
| })); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void queryTypeTimestampWithoutTimezoneTest(TestContext context) throws Exception { | ||
| Async async = context.async(); | ||
| client.getConnection(connAr -> { | ||
| ensureSuccess(context, connAr); | ||
| conn = connAr.result(); | ||
| conn.execute("DROP TABLE IF EXISTS test_table", onSuccess(context, dropped -> { | ||
| conn.execute("CREATE TABLE IF NOT EXISTS test_table (ts timestamp without time zone)", onSuccess(context, created -> { | ||
| conn.execute("INSERT INTO test_table (ts) VALUES (now())", onSuccess(context, inserted -> { | ||
| conn.query("SELECT * FROM test_table;", onSuccess(context, timestampSelect -> { | ||
| context.assertNotNull(timestampSelect); | ||
| context.assertNotNull(timestampSelect.getResults()); | ||
| context.assertTrue(timestampSelect.getResults().get(0).getString(0).matches("\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}\\.\\d{3}")); | ||
|
Contributor
Author
There was a problem hiding this comment. @pmlopes and this checks that there is no timezone info available here. |
||
| async.complete(); | ||
| })); | ||
| })); | ||
| })); | ||
| })); | ||
| }); | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmlopes this would be the check I mentioned over there: 14bb98b#commitcomment-16058891