org.joda.time.DateTime

[augeneinblick]

#4 fixes the case for (postgresql) column type "timestamp without time zone", but not for type "timestamp with time zone". Manually tested with current version 3.2.0.

"timestamp with time zone" leads to org.joda.time.DateTime which is not supported in io.vertx.core.json.impl.Json.checkAndCopy.

I'm a vertx-newb so perhaps i'm getting something wrong. If not i would be happy to be able to contribute a small patch :).

[Narigo]

@augeneinblick Can you give me an example on what exactly is wrong here? Could you maybe add a test that validates the issue?

[Narigo]

I guess giving me a code snippet on how you use it, would suffice. :)

[augeneinblick]

I forked and added a testcase which fails due the bug i meant above (sorry for missing creating a branch):
testcase

The exception is:
java.lang.IllegalStateException: Illegal type in JsonObject: class org.joda.time.DateTime at io.vertx.core.json.Json.checkAndCopy(Json.java:120) at io.vertx.core.json.JsonArray.add(JsonArray.java:437) at io.vertx.ext.asyncsql.impl.AsyncSQLConnectionImpl$2.apply(AsyncSQLConnectionImpl.java:286)

The type "timestamp without time zone" will deliver a DateTime object to AsyncSQLConnectionImpl:286 which only handles LocalDateTime -
so "timestamp with time zone" -> LocalDateTime (okay),
"timestamp without timezone" -> DateTime. (fails)

possible quickfix
with two testcases

on branch: issue34timestamp

[Narigo]

@augeneinblick if you want to contribute directly, you could also send a pull request - but you need to sign the Eclipse CLA before I would be able to merge it. See https://github.com/vert-x3/vertx-mysql-postgresql-client/blob/master/CONTRIBUTING.md

Otherwise, I see that I should do some changes to the tests anyways and could be able to implement those later today (after some sleep ;)).

[Narigo]

If someone could review #37 now, we can merge and close this issue :)
Thanks!

[ghulands]

What release will this be going into?

[Narigo]

Hopefully the next one :)

@vietj can we accelerate releases? I mean, would be nice to have releases that do not necessarily match a Vert.x release...?

[vietj]

what do you mean ? you want a new release of mysql based on Vert.x 3.2.1 ?