Skip to content

Issue34timestamp #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Issue34timestamp #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8527971
testcase for psql query of a column with type 'timestamp with time zo…
augeneinblick Feb 5, 2016
24313bc
quickfix for selecting psql column type 'timezone without time zone'.
augeneinblick Feb 5, 2016
1b8c426
test both timestamp types.
augeneinblick Feb 5, 2016
fe9f5d1
clean timestamp testtable after test.
augeneinblick Feb 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/io/vertx/ext/asyncsql/impl/AsyncSQLConnectionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import io.vertx.ext.sql.ResultSet;
import io.vertx.ext.sql.SQLConnection;
import io.vertx.ext.sql.UpdateResult;
import org.joda.time.DateTime;
import org.joda.time.LocalDate;
import org.joda.time.LocalDateTime;
import scala.Option;
Expand Down Expand Up @@ -282,6 +283,8 @@ public Void apply(Object value) {
array.add(value.toString());
} else if (value instanceof UUID) {
array.add(value.toString());
} else if (value instanceof DateTime) {
array.add(value.toString());
} else {
array.add(value);
}
Expand Down
49 changes: 49 additions & 0 deletions src/test/java/io/vertx/ext/asyncsql/PostgreSQLTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,53 @@ public void someTest() throws Exception {
await();
}

@Test
public void queryTypeTimestampWithTimezoneTest() throws Exception {
asyncSqlClient.getConnection(onSuccess(conn -> {
conn.execute("CREATE TABLE IF NOT EXISTS timestamptest (ts timestamp with time zone)", onSuccess(resultSet -> {
conn.execute("INSERT INTO timestamptest (ts) VALUES (now())", onSuccess(rs1 -> {
conn.query("SELECT * FROM timestamptest;", onSuccess(rs2 -> {
assertNotNull(rs2);
assertNotNull(rs2.getResults());
Copy link
Contributor

@Narigo Narigo Feb 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add at least some check that the data received is a correctly formed date or something like that.

conn.execute("DROP TABLE timestamptest", onSuccess(rs3 -> {
Copy link
Contributor

@Narigo Narigo Feb 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I'd recommend dropping the table before the test and not after it. You can then check the database if anything strange happened after running the test.

conn.close((ar) -> {
if (ar.succeeded()) {
testComplete();
} else {
fail("should be able to close the asyncSqlClient");
}
});
}));
}));
}));
}));
}));

await();
}

@Test
public void queryTypeTimestampWithoutTimezoneTest() throws Exception {
asyncSqlClient.getConnection(onSuccess(conn -> {
conn.execute("CREATE TABLE IF NOT EXISTS timestamptest (ts timestamp without time zone)", onSuccess(resultSet -> {
conn.execute("INSERT INTO timestamptest (ts) VALUES (now())", onSuccess(rs1 -> {
conn.query("SELECT * FROM timestamptest;", onSuccess(rs2 -> {
assertNotNull(rs2);
assertNotNull(rs2.getResults());
conn.execute("DROP TABLE timestamptest", onSuccess(rs3 -> {
Copy link
Contributor

@Narigo Narigo Feb 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this test: Drop table before starting the test and assert that the received result is a correctly formed date.

conn.close((ar) -> {
if (ar.succeeded()) {
testComplete();
} else {
fail("should be able to close the asyncSqlClient");
}
});
}));
}));
}));
}));
}));

await();
}
}