[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

MananTank · 2025-09-24T18:52:15Z

PR-Codex overview

This PR simplifies the handlePostBuyTransactionComplete function in the BridgeOrchestrator component by removing the quote parameter and associated logic, streamlining the transaction completion process.

Detailed summary

Removed the quote parameter from handlePostBuyTransactionComplete.
Eliminated the call to onComplete?.(quote) within handlePostBuyTransactionComplete.
Updated the closeModal prop in ExecutingTxScreen to directly use handlePostBuyTransactionComplete.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2025-09-24T18:52:19Z

MNY-200 Fix onSuccess callback timing for TransactionWidget

changeset-bot · 2025-09-24T18:52:20Z

⚠️ No Changeset found

Latest commit: a83104e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-09-24T18:52:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	Ready	Preview	Comment	Sep 24, 2025 10:34pm
nebula	Ready	Preview	Comment	Sep 24, 2025 10:34pm
thirdweb_playground	Ready	Preview	Comment	Sep 24, 2025 10:34pm
thirdweb-www	Ready	Preview	Comment	Sep 24, 2025 10:34pm
wallet-ui	Ready	Preview	Comment	Sep 24, 2025 10:34pm

coderabbitai · 2025-09-24T18:52:23Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch mny-200

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

MananTank · 2025-09-24T18:52:42Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-09-24T18:57:34Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	64.07 KB (0%)	1.3 s (0%)	447 ms (+90.1% 🔺)	1.8 s
thirdweb (cjs)	361.6 KB (0%)	7.3 s (0%)	2.4 s (+8.24% 🔺)	9.6 s
thirdweb (minimal + tree-shaking)	5.73 KB (0%)	115 ms (0%)	123 ms (+880.49% 🔺)	237 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	84 ms (+1515.61% 🔺)	95 ms
thirdweb/react (minimal + tree-shaking)	19.14 KB (0%)	383 ms (0%)	96 ms (+758.5% 🔺)	479 ms

codecov · 2025-09-24T19:23:46Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.28%. Comparing base (7936ebb) to head (a83104e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...web/src/react/web/ui/Bridge/BridgeOrchestrator.tsx	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8119      +/-   ##
==========================================
+ Coverage   56.24%   56.28%   +0.03%     
==========================================
  Files         906      906              
  Lines       59193    59190       -3     
  Branches     4169     4176       +7     
==========================================
+ Hits        33293    33313      +20     
+ Misses      25797    25772      -25     
- Partials      103      105       +2

Flag	Coverage Δ
packages	`56.28% <0.00%> (+0.03%)`	⬆️

Files with missing lines	Coverage Δ
...web/src/react/web/ui/Bridge/BridgeOrchestrator.tsx	`6.71% <0.00%> (+0.07%)`	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app · 2025-09-24T20:13:38Z

Merge activity

Sep 24, 8:13 PM UTC: MananTank added this pull request to the Graphite merge queue.
Sep 24, 8:29 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #8113.
Sep 24, 9:47 PM UTC: MananTank added this pull request to the Graphite merge queue.
Sep 24, 10:11 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #8117.
Sep 24, 10:11 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #8117.
Sep 24, 10:47 PM UTC: MananTank added this pull request to the Graphite merge queue.
Sep 24, 10:49 PM UTC: Merged by the Graphite merge queue.

…ransactionWidget (#8119)   --- ## PR-Codex overview This PR simplifies the `handlePostBuyTransactionComplete` function in the `BridgeOrchestrator` component by removing the `quote` parameter and the associated call to `onComplete`. It streamlines the transaction completion process and adjusts the `closeModal` prop accordingly. ### Detailed summary - Removed the `quote` parameter from the `handlePostBuyTransactionComplete` function. - Eliminated the call to `onComplete?.(quote)` within the `handlePostBuyTransactionComplete` function. - Updated the `closeModal` prop in the `ExecutingTxScreen` component to directly use `handlePostBuyTransactionComplete` without arguments. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

MananTank mentioned this pull request Sep 24, 2025

[MNY-196] SDK: Add SwapWidget render event #8113

Merged

MananTank mentioned this pull request Sep 24, 2025

[MNY-180] SDK: Fix TransactionWidget not respecting currency prop #8118

Merged

MananTank mentioned this pull request Sep 24, 2025

[MNY-201] SDK: Rename leftover of Universal Bridge to Bridge #8117

Merged

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Sep 24, 2025

MananTank marked this pull request as ready for review September 24, 2025 18:52

github-actions bot assigned MananTank Sep 24, 2025

MananTank requested review from a team as code owners September 24, 2025 18:52

This was referenced Sep 24, 2025

[MNY-198] SDK: Fix StepRunner autoStart not working reliably, Remove extra prepare call #8116

Merged

[MNY-197] SDK: SwapWidget chain selection UI improvements #8115

Merged

vercel bot deployed to Preview – nebula September 24, 2025 18:55 View deployment

vercel bot deployed to Preview – thirdweb-www September 24, 2025 19:02 View deployment

joaquim-verges approved these changes Sep 24, 2025

View reviewed changes

vercel bot deployed to Preview – docs-v2 September 24, 2025 20:07 View deployment

vercel bot deployed to Preview – thirdweb_playground September 24, 2025 20:11 View deployment

vercel bot deployed to Preview – wallet-ui September 24, 2025 20:13 View deployment

jakeloo approved these changes Sep 24, 2025

View reviewed changes

graphite-app bot force-pushed the mny-180 branch from 0673b89 to 7936ebb Compare September 24, 2025 21:44

graphite-app bot force-pushed the mny-200 branch from f5c6250 to a83104e Compare September 24, 2025 21:45

vercel bot deployed to Preview – nebula September 24, 2025 21:46 View deployment

vercel bot deployed to Preview – thirdweb-www September 24, 2025 21:53 View deployment

vercel bot deployed to Preview – wallet-ui September 24, 2025 22:31 View deployment

vercel bot deployed to Preview – docs-v2 September 24, 2025 22:33 View deployment

vercel bot deployed to Preview – thirdweb_playground September 24, 2025 22:34 View deployment

Base automatically changed from mny-180 to main September 24, 2025 22:48

graphite-app bot merged commit a83104e into main Sep 24, 2025
22 of 23 checks passed

graphite-app bot deleted the mny-200 branch September 24, 2025 22:49

vercel bot deployed to Production – nebula September 24, 2025 22:54 View deployment

vercel bot deployed to Production – wallet-ui September 24, 2025 23:03 View deployment

vercel bot deployed to Production – thirdweb-www September 24, 2025 23:05 View deployment

vercel bot deployed to Production – thirdweb_playground September 24, 2025 23:06 View deployment

vercel bot deployed to Production – docs-v2 September 24, 2025 23:17 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

Uh oh!

MananTank commented Sep 24, 2025 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Sep 24, 2025

Uh oh!

changeset-bot bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

vercel bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 24, 2025 •

edited

Loading

Review skipped

Uh oh!

MananTank commented Sep 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

Uh oh!

Conversation

MananTank commented Sep 24, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Sep 24, 2025

Uh oh!

changeset-bot bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

MananTank commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MananTank commented Sep 24, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented Sep 24, 2025 •

edited

Loading

vercel bot commented Sep 24, 2025 •

edited

Loading

coderabbitai bot commented Sep 24, 2025 •

edited

Loading

MananTank commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading

codecov bot commented Sep 24, 2025 •

edited

Loading

graphite-app bot commented Sep 24, 2025 •

edited

Loading