Skip to content

[MNY-197] SDK: SwapWidget chain selection UI improvements #8115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

[MNY-197] SDK: SwapWidget chain selection UI improvements #8115

merged 1 commit into from
Sep 24, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Sep 24, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the user experience in the swap widget by updating callback functions and enhancing the selection of tokens and chains. It refines state management and ensures selected tokens are handled correctly.

Detailed summary

  • Changed onBack to onClose in SelectToken components.
  • Updated modal state management to close modals correctly.
  • Introduced initiallySelectedChain to prioritize the selected chain in SelectBridgeChainUI.
  • Filtered chains based on the newly sorted array.
  • Modified onSelectToken to call onClose after setting the selected token in SelectTokenUI.
  • Enhanced token selection logic to include chain ID validation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Sep 24, 2025

MNY-197 Highlight selected chain in token selection screen on top

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8dc9e41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Sep 24, 2025 8:37pm
nebula Ready Ready Preview Comment Sep 24, 2025 8:37pm
thirdweb_playground Ready Ready Preview Comment Sep 24, 2025 8:37pm
thirdweb-www Ready Ready Preview Comment Sep 24, 2025 8:37pm
wallet-ui Ready Ready Preview Comment Sep 24, 2025 8:37pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mny-197

Comment @coderabbitai help to get the list of available commands and usage tips.

@MananTank MananTank marked this pull request as ready for review September 24, 2025 18:01
@MananTank MananTank requested review from a team as code owners September 24, 2025 18:01
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Sep 24, 2025
@MananTank MananTank mentioned this pull request Sep 24, 2025
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented Sep 24, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.07 KB (0%) 1.3 s (0%) 211 ms (+258.23% 🔺) 1.5 s
thirdweb (cjs) 361.6 KB (0%) 7.3 s (0%) 616 ms (+18.96% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 102 ms (+2900.01% 🔺) 216 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 55 ms (+4060.01% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.14 KB (0%) 383 ms (0%) 96 ms (+3320.01% 🔺) 479 ms

This was referenced Sep 24, 2025
Merged
Merged
@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.26%. Comparing base (33fc3e5) to head (8dc9e41).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8115      +/-   ##
==========================================
- Coverage   56.27%   56.26%   -0.02%     
==========================================
  Files         906      906              
  Lines       59208    59208              
  Branches     4184     4175       -9     
==========================================
- Hits        33317    33311       -6     
- Misses      25785    25794       +9     
+ Partials      106      103       -3
Flag Coverage Δ
packages 56.26% <ø> (-0.02%) ⬇️
see 5 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank mentioned this pull request Sep 24, 2025
Merged
@MananTank MananTank mentioned this pull request Sep 24, 2025
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 24, 2025 •
edited
Loading

Merge activity

@MananTank
[MNY-197] SDK: SwapWidget chain selection UI improvements (#8115)
8dc9e41 
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the user experience in the `SwapUI` and `SelectTokenUI` components by updating callback functions and enhancing token selection logic.

### Detailed summary
- Changed `onBack` prop to `onClose` in `SelectToken` and `SelectTokenUI` components.
- Updated modal state management to close modals on token selection.
- Introduced `initiallySelectedChain` to prioritize the selected chain in `SelectBridgeChainUI`.
- Enhanced filtering logic for token selection to consider chain IDs.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Base automatically changed from mny-196 to main September 24, 2025 20:35
@graphite-app graphite-app bot merged commit 8dc9e41 into main Sep 24, 2025
23 checks passed
@graphite-app graphite-app bot deleted the mny-197 branch September 24, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @joaquim-verges