Skip to content

[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

[MNY-200] SDK: Fix onSuccess callback not called when tx is sent in TransactionWidget #8119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,9 @@
}, [send, uiOptions.mode]);

// Handle post-buy transaction completion
const handlePostBuyTransactionComplete = useCallback(
(quote: BridgePrepareResult) => {
onComplete?.(quote);
send({ type: "RESET" });
},
[onComplete, send],
);
const handlePostBuyTransactionComplete = useCallback(() => {
send({ type: "RESET" });
}, [send]);

Check warning on line 194 in packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx#L192-L194 

Added lines #L192 - L194 were not covered by tests

// Handle errors
const handleError = useCallback(
Expand Down Expand Up @@ -416,9 +412,9 @@
quote &&
uiOptions.transaction && (
<ExecutingTxScreen
closeModal={() => handlePostBuyTransactionComplete(quote)}
closeModal={handlePostBuyTransactionComplete}

Check warning on line 415 in packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx#L415 

Added line #L415 was not covered by tests
onTxSent={() => {
// Do nothing
onComplete?.(quote);

Check warning on line 417 in packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx#L417 

Added line #L417 was not covered by tests
}}
tx={uiOptions.transaction}
windowAdapter={webWindowAdapter}
Expand Down
Loading