-
Notifications
You must be signed in to change notification settings - Fork 617
[MNY-198] SDK: Fix StepRunner autoStart not working reliably, Remove extra prepare call #8116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8116 +/- ##
==========================================
+ Coverage 56.26% 56.27% +0.01%
==========================================
Files 906 906
Lines 59208 59191 -17
Branches 4175 4175
==========================================
- Hits 33311 33310 -1
+ Misses 25794 25776 -18
- Partials 103 105 +2
🚀 New features to boost your workflow:
|
Merge activity
|
…extra prepare call (#8116) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on enhancing the `StepRunner` component in the Bridge UI by integrating a `preparedQuote` prop, improving the handling of swap transactions, and refining the relevant hooks and stories. ### Detailed summary - Added `preparedQuote` prop to `SwapWidget` and `StepRunner`. - Updated `StepRunner` to utilize `preparedQuote` for executing steps. - Modified `useStepExecutor` to accept `preparedQuote` instead of `request`. - Cleaned up imports in `useStepExecutor`. - Updated stories to reflect the new `preparedQuote` prop. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
137efcc to
8dc9e41
Compare
0e39790 to
ee4e13e
Compare

PR-Codex overview
This PR focuses on enhancing the
StepRunnercomponent by integrating apreparedQuoteprop, which improves functionality related to handling transaction quotes in the swap process.Detailed summary
preparedQuoteprop toStepRunner,SwapWidget, andBridgeOrchestrator.StepRunnerPropsinterface to includepreparedQuote.useStepExecutorto acceptpreparedQuoteinstead of a request.StepRunnerto usesimpleBuyQuote.