[MNY-180] SDK: Fix TransactionWidget not respecting currency prop #8118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
This was referenced Sep 24, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
size-limit report 📦
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8118 +/- ##
==========================================
- Coverage 56.27% 56.24% -0.03%
==========================================
Files 906 906
Lines 59191 59193 +2
Branches 4171 4169 -2
==========================================
- Hits 33308 33293 -15
- Misses 25778 25797 +19
+ Partials 105 103 -2
🚀 New features to boost your workflow:
|
joaquim-verges
approved these changes
Sep 24, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
09-25-sdk_rename_leftover_of_universal_bridge_to_bridge
branch
2 times, most recently
from
2d05ee0 to
89acabc
Compare
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the handling of the `currency` property in various components and adding a new story for a transaction mode in light theme that showcases an ERC20 token transfer. ### Detailed summary - Changed `currency` from optional to required in `useTransactionDetails.ts`. - Added `currency` to the props in `PaymentOverview.tsx` and `TransactionPayment.tsx`. - Introduced a new story `TransactionJPYCurrency` in `BridgeOrchestrator.stories.tsx` for displaying an ERC20 token transfer in light theme. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
09-25-sdk_rename_leftover_of_universal_bridge_to_bridge
branch
from
89acabc to
3b986d5
Compare
graphite-app
bot
force-pushed
the
mny-180
branch
from
0673b89 to
7936ebb
Compare
Base automatically changed from
09-25-sdk_rename_leftover_of_universal_bridge_to_bridge
to
main
September 24, 2025 22:48
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the handling of currency in transaction details across various components in the
thirdwebpackage, ensuring better support for undefined currency values and introducing a new story for displaying a transaction in JPY.Detailed summary
currencyproperty inuseTransactionDetails.tsto allowundefined.currencyto the transaction details inPaymentOverview.tsx.currencyin the transaction data forTransactionPayment.tsx.TransactionJPYCurrencyfor ERC20 token transfer in light theme, specifying JPY as the currency.