Skip to content

Conversation

@sidolov
Copy link
Contributor

@sidolov sidolov commented Oct 5, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

mzeis and others added 30 commits February 27, 2018 20:13
…lso mode is to just show 'static block' magento#1159

 - Merge Pull Request magento-engcom/magento2ce#1159 from RomaKis/magento2ce:7765
 - Merged commits:
   1. 39e0fd9
…ge after redirect for force password change magento#13787

 - Merge Pull Request magento#13787 from comwrap/magento2:Issue-13768
 - Merged commits:
   1. 96a8b58
…gento#13828

 - Merge Pull Request magento#13828 from chickenland/magento2:2.2-develop
 - Merged commits:
   1. 96c1320
   2. 5d1e713
…nabled translate-inline magento#13038

 - Merge Pull Request magento#13038 from pareshpansuriya/magento2:2.2-develop
 - Merged commits:
   1. 6144c4f
   2. 7e913f1
   3. cbc704d
Accepted Public Pull Requests:
 - magento#13844: Fix issue 13827 (by @julienanquetil)
 - magento#13817: Allow changing head and body element through xml layout updates (by @cedricziel)
 - magento#13567: Add integration tests for product urls rewrite generation (by @adrien-louis-r)
 - magento#13038: Default Welcome message is broken on storefront with enabled translate-inline (by @pareshpansuriya)
 - magento#13828: Inconsistent Redirect in Admin Notification Controller (by @chickenland)
 - magento#13787: Issue-13768 Fixed error messages on admin user account page after redirect for force password change (by @nuzil)


Fixed GitHub Issues:
 - magento#13350: Magento 2.2 Encoding Issue -> Google Analytics (reported by @danielpfarmer) has been fixed in magento#13844 by @julienanquetil in 2.2-develop branch
   Related commits:
     1. 5843e81
     2. 0d5197f

 - magento#13827: Google Analytics character encoding issue ( \u0020 ) (reported by @Munszu) has been fixed in magento#13844 by @julienanquetil in 2.2-develop branch
   Related commits:
     1. 5843e81
     2. 0d5197f

 - magento#4454: CMS Page with <head> in layout update xml (reported by @zhiyicai) has been fixed in magento#13817 by @cedricziel in 2.2-develop branch
   Related commits:
     1. 341cdaf

 - magento#5863: URL Rewrite issues occur very often /catalog/product/view/id/711/s/product-name/category/16/ (reported by @kayintveen) has been fixed in magento#13567 by @adrien-louis-r in 2.2-develop branch
   Related commits:
     1. 1ef4dcc
     2. 864f371

 - magento#8227: After upgrade to 2.1.3 url rewrite problem multi store (reported by @philipvandebriel) has been fixed in magento#13567 by @adrien-louis-r in 2.2-develop branch
   Related commits:
     1. 1ef4dcc
     2. 864f371

 - magento#8957: Permanent Redirect for old URL missing via API (reported by @MarcoGrecoBitbull) has been fixed in magento#13567 by @adrien-louis-r in 2.2-develop branch
   Related commits:
     1. 1ef4dcc
     2. 864f371

 - magento#10073: Magento don't create product redirect if URL key on store view level was changed. (reported by @sergei-sss) has been fixed in magento#13567 by @adrien-louis-r in 2.2-develop branch
   Related commits:
     1. 1ef4dcc
     2. 864f371

 - magento#13240: Permanent 301 redirect is not generated when product url changes on storeview scope (reported by @koenner01) has been fixed in magento#13567 by @adrien-louis-r in 2.2-develop branch
   Related commits:
     1. 1ef4dcc
     2. 864f371

 - magento#12711: Default Welcome message is broken on storefront with enabled translate-inline (reported by @alena-marchenko) has been fixed in magento#13038 by @pareshpansuriya in 2.2-develop branch
   Related commits:
     1. 6144c4f
     2. 7e913f1
     3. cbc704d

 - magento#13768: Expired backend password - Attention: Something went wrong (reported by @janssensjelle) has been fixed in magento#13787 by @nuzil in 2.2-develop branch
   Related commits:
     1. 96a8b58
…nder. magento#13878

 - Merge Pull Request magento#13878 from pawcioma/magento2:issues-13769-info-about-sent-email
 - Merged commits:
   1. 1c7e3a1
 - Merge Pull Request magento#13897 from pmclain/magento2:type/security-di
 - Merged commits:
   1. d77d6e9
Oleksandr Iegorov and others added 21 commits March 15, 2018 09:28
 - Additionally updated Travis CI branch link
…1453

 - Merge Pull Request magento-engcom/magento2ce#1453 from magento-engcom/magento2ce:codetriage-badge-2.2
 - Merged commits:
   1. 696f9dc
…to#14121

 - Merge Pull Request magento#14121 from magento/magento2:2.2-develop-PR-port-14016
 - Merged commits:
   1. 8cfffc1
…mework\Encryption\Encryptor::getHash magento#13884

 - Merge Pull Request magento#13884 from k4emic/magento2:2.2-develop-5463
 - Merged commits:
   1. adab3e5
Fixed issues:
  - MAGETWO-77754 [2.2.x] - Related Products Rule for Up-sell Products with Customer Segments Specified Doesn't Work
  - MAGETWO-87570 [2.2.x] "Hide from Product Page" option does not work for child of configurable product
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#12929: Issues magento#10559 - Extend swatch using mixins (M2.2) (by @srenon)
 - magento#14121: [Backport] Open link "Report an Issue" in a new tab (by @sidolov)
 - magento-engcom/magento2ce#1453: [2.2] Add a CodeTriage badge to magento/magento2 (by @ishakhsuvarov)
 - magento#14105: magento#13820: IE11 minicart not updating on configurable pr� (by @Frodigo)
 - magento#13989: Act better on existing input focus instead of removing it (by @krzksz)
 - magento#14083: Fix product attribute ordering when more than 10 attributes. (by @RandeKnight)
 - magento#14029: Fix $useCache for container child blocks (by @tdgroot)
 - magento#14062: Typo in SSL port number (by @jasperzeinstra)
 - magento#14042: Improve array output format for etc.php and config.php (by @avstudnitz)
 - magento#13894: Fix cache issue for currencies with no symbol (by @evgk)
 - magento#13884: magento#5463 - Use specified hashing algo in \Magento\Framework\Encryption\Encryptor::getHash (by @k4emic)
 - magento-engcom/magento2ce#1258: magento#13231: Default State or Province is not pre-selected in the Estimate Shipping and Tax (by @serhii-balko)


Fixed GitHub Issues:
 - magento#10559: Extending swatch functionality using javascript mixins does not work in Safari and MS Edge (reported by @srenon) has been fixed in magento#12929 by @srenon in 2.2-develop branch
   Related commits:
     1. 1350c77
     2. 33261e0
     3. 4fca69d
     4. 97779a6
     5. 494c9c0
     6. 20b9575
     7. 089b468
     8. ca471e4
     9. c84087e
     10. ec51bd2
     11. d4fa8a5

 - magento#14010: Why Report Bugs link not open in new tab? (reported by @webshouters) has been fixed in magento#14121 by @sidolov in 2.2-develop branch
   Related commits:
     1. 8cfffc1

 - magento#13820: IE11 minicart not updating on configurable product page (ES6) (reported by @Pumppa) has been fixed in magento#14105 by @Frodigo in 2.2-develop branch
   Related commits:
     1. 2235f3e

 - magento#13988: Mini search field looses focus after its JavaScript is initialized (reported by @krzksz) has been fixed in magento#13989 by @krzksz in 2.2-develop branch
   Related commits:
     1. 9eb3c6f

 - magento#5463: The ability to store passwords using different hashing algorithms is limited (reported by @maderlock) has been fixed in magento#13884 by @k4emic in 2.2-develop branch
   Related commits:
     1. adab3e5

 - magento#13231: Default State or Province is not pre-selected in the Estimate Shipping and Tax (reported by @hanxiangwu) has been fixed in magento-engcom/magento2ce#1258 by @serhii-balko in 2.2-develop branch
   Related commits:
     1. 0cabe58
     2. 0ad6208
     3. e26c22f
     4. 7b0a489
     5. 35fb319
     6. 5837d36
     7. 4d50066
     8. 04e573a
@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2020

Hi @sidolov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Oct 5, 2020

Hi @sidolov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.