#5463 - Use specified hashing algo in \Magento\Framework\Encryption\Encryptor::getHash

[k4emic]

Description

\Magento\Framework\Encryption\Encryptor::getHash would previously ignore the specified hashing algorithm version that was supplied

Fixed Issues (if relevant)

1. The ability to store passwords using different hashing algorithms is limited #5463: The ability to store passwords using different hashing algorithms is limited

Manual testing scenarios

N/A, Magento currently has no support for specifying hashing algorithms by default.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[ihor-sviziev]

Why haven't you passed $version variable at line 146?
https://github.com/magento/magento2/pull/13884/files#diff-07981c7827bdf60bd9649fa9f8ec974dR146

[k4emic]

@ihor-sviziev This was an oversight on my part. I've updated the code and added coverage for it in the unit test.

[ihor-sviziev]

@k4emic now your changes looks good. Could you squash your changes into 1 commit and force push to your branch?
Also here is static test failure. Please fix it.
Then I'll approve your PR

[k4emic]

@ihor-sviziev Done. Let me know if I missed something.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-618 has been created to process this Pull Request

[magento-engcom-team]

@k4emic thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

@k4emic thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.