Permanent 301 redirect is not generated when product url changes on storeview scope

[koenner01]

When changing a product's url in the backend on storeview scope, there is no 301 rewrite being generated.

Preconditions

1. PHP7
2. CE 2.2.2 (we previously tested this issue too on 2.1.7+ and it existed there too)

Steps to reproduce

1. Create a website and add multiple storeviews to it
2. Create a product, add it to your new website and then save it
3. Now change the store scope on the product detail in the backend to a storeview and change the product's url (make sure the checkbox for 'Create Permanent Redirect for old URL' is checked!)

Expected result

1. A 301 redirect for the product's old url should've been created for choosen storeview

Actual result

1. No 301 redirect is created

Weird thing is that if you update the url on 'all storeviews' scope it will create a 301 redirect for every storeview using the default value, so logic for the redirects must exist..
Not gonna bother going deeper into this issue as it's probably gonna be in the core depths of the magento (hell)

[magento-engcom-team]

@koenner01, thank you for your report.
We've acknowledged the issue and added to our backlog.

[diwipl]

I think I've found what the issue is.

https://github.com/magento/magento2/blob/2.2/app/code/Magento/CatalogUrlRewrite/Observer/ProductProcessUrlRewriteSavingObserver.php#L53-L58

Those lines remove old url_rewrite table entries for product for specified store view, but it is done before new redirects from old urls are generated. Because of that redirects cannot be generated because old urls does not exist anymore in database.

Removing those lines fixed the issue for me, but I cannot easily predict consequences of such modification in all parts of system.

The reason why generation of redirects works for "All store views" is because 0 is passed as store id and url_rewrite table never contains entries with store_id equal to 0 (or at least in any Magento 2 database that I saw) so essentially nothing is removed and thus it is possible to generate redirects for old urls.

[magento-engcom-team]

Hi @koenner01. Thank you for your report.
The issue has been fixed in #13567 by @adrien-louis-r in 2.2-develop branch
Related commit(s):

• 1ef4dcc110062612e9971d7f8fb788bef213df3f
• 864f371aed88884fb73082deb0c856819c43a41f

The fix will be available with the upcoming 2.2.4 release.