Skip to content

Conversation

@tdgroot
Copy link
Member

@tdgroot tdgroot commented Mar 9, 2018

Description

This is a follow-up from PR #4919.

When one would use getChildHtml() like the following to output a container uncached:
<?= $block->getChildHtml('category.products.list.product_meta', false); ?>
The container's child blocks would still be cached.

Fixed Issues (if relevant)

  1. getChildHtml, $useCache and child containers #4919: getChildHtml, $useCache and child containers

Manual testing scenarios

  1. Add a container to block category.products.list.
  2. Add a custom template to the container and output something that should be different every time it gets rendered, like <?= rand() ?>.
  3. Output the container in Magento/Catalog/templates/products/list.phtml using getChildHtml() and set $useCache to false.
  4. The output is the same with each getChildHtml() of the container.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-887 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@tdgroot thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@tdgroot
Copy link
Member Author

tdgroot commented Mar 13, 2018

@magento-engcom-team @miguelbalparda Thanks for considering my pull request. I joined the organization!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants