🔃 [Magento Community Engineering] Community Contributions - 2.3-develop latest changes

Accepted Community Pull Requests:
 - #25024: Quality Assurance > Missing PHPDoc comment (by @lfluvisotto)
 - #25034: Resolve "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run) #25033 (by @edenduong)
 - #24959: Fix for #23577. Check if db tables for config data exists before fetch (by @ivan-koliadynskyy)
 - #24899: Static Content Deploy - Add command line argument to disable JS Bundles (by @andrey-legayev)
 - #24898: DI Compile - Sort DI metadata output to make diff between builds easier (by @andrey-legayev)
 - #24345: Sales - fix displaying available allowed countries while editing order address in Admin panel (by @oleksii-lisovyi)
 - #24981: Fixed required class is missing in load template (by @gauravagarwal1001)
 - #25064: Updated strings and XML comments. (by @sanganinamrata)


Fixed GitHub Issues:
 - #25033: "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run) (reported by @edenduong) has been fixed in #25034 by @edenduong in 2.3-develop branch
   Related commits:
     1. f68dd1c

 - #23577: Since 2.3.2, we can no longer switch maintenance modes with an empty database (reported by @hostep) has been fixed in #24959 by @ivan-koliadynskyy in 2.3-develop branch
   Related commits:
     1. 813f1d7
     2. c252363
     3. 9e88279
     4. ee6e8a6
     5. 20e46ff
     6. 55a5748
     7. 0a083be
     8. c579195

 - #12560: Back-End issue for multi-store website: when editing Order shipping/billing address - allowed countries are selected from wrong Store View   (reported by @svejegres) has been fixed in #24345 by @oleksii-lisovyi in 2.3-develop branch
   Related commits:
     1. d617c3c
     2. 883d9f5

Author: magento-engcom-team

app/code/Magento/AuthorizenetAcceptjs/Test/Unit/Gateway/ConfigTest.php

@@ -81,6 +81,9 @@ public function testGetSolutionIdSandbox($environment, $expectedSolution)
         $this->assertEquals($expectedSolution, $this->model->getSolutionId(123));
     }
 
+    /**
+     * @return array
+     */
     public function configMapProvider()
     {
         return [
@@ -97,6 +100,10 @@ public function configMapProvider()
             ['getTransactionInfoSyncKeys', 'transactionSyncKeys', 'a,b,c', ['a', 'b', 'c']],
         ];
     }
+
+    /**
+     * @return array
+     */
     public function environmentUrlProvider()
     {
         return [
@@ -105,6 +112,9 @@ public function environmentUrlProvider()
         ];
     }
 
+    /**
+     * @return array
+     */
     public function environmentSolutionProvider()
     {
         return [

app/code/Magento/AuthorizenetAcceptjs/Test/Unit/Gateway/Request/AddressDataBuilderTest.php

@@ -108,13 +108,22 @@ public function testBuildWithBothAddresses()
         $this->assertEquals('abc', $result['transactionRequest']['customerIP']);
     }
 
+    /**
+     * @param $responseData
+     * @param $addressPrefix
+     */
     private function validateAddressData($responseData, $addressPrefix)
     {
         foreach ($this->mockAddressData as $fieldValue => $field) {
             $this->assertEquals($addressPrefix . $field['sampleData'], $responseData[$fieldValue]);
         }
     }
 
+    /**
+     * @param $prefix
+     *
+     * @return \PHPUnit\Framework\MockObject\MockObject
+     */
     private function createAddressMock($prefix)
     {
         $addressAdapterMock = $this->createMock(AddressAdapterInterface::class);

app/code/Magento/AuthorizenetAcceptjs/Test/Unit/Gateway/Response/PaymentReviewStatusHandlerTest.php

@@ -112,6 +112,9 @@ public function testDoesNothingWhenPending(string $status)
         $this->handler->handle($subject, $response);
     }
 
+    /**
+     * @return array
+     */
     public function pendingTransactionStatusesProvider()
     {
         return [
@@ -120,6 +123,9 @@ public function pendingTransactionStatusesProvider()
         ];
     }
 
+    /**
+     * @return array
+     */
     public function declinedTransactionStatusesProvider()
     {
         return [

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductGridActionGroup.xml

@@ -389,7 +389,7 @@
         <waitForPageLoad stepKey="waitForGridLoad"/>
     </actionGroup>
 
-    <!--Filter and select the the product  -->
+    <!--Filter and select the product  -->
     <actionGroup name="filterAndSelectProduct">
         <annotations>
             <description>Goes to the Admin Products grid. Filters the Product grid by the provided Product SKU.</description>

app/code/Magento/Catalog/Test/Unit/Model/Category/FileInfoTest.php

@@ -191,6 +191,9 @@ public function testIsExist($fileName, $fileMediaPath)
         $this->assertTrue($this->model->isExist($fileName));
     }
 
+    /**
+     * @return array
+     */
     public function isExistProvider()
     {
         return [
@@ -213,6 +216,9 @@ public function testIsBeginsWithMediaDirectoryPath($fileName, $expected)
         $this->assertEquals($expected, $this->model->isBeginsWithMediaDirectoryPath($fileName));
     }
 
+    /**
+     * @return array
+     */
     public function isBeginsWithMediaDirectoryPathProvider()
     {
         return [

app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php

@@ -486,6 +486,9 @@ public function testGetStoreSingleSiteModelIds(
         $this->assertEquals($websiteIDs, $this->model->getStoreIds());
     }
 
+    /**
+     * @return array
+     */
     public function getSingleStoreIds()
     {
         return [

app/code/Magento/Checkout/Test/Mftf/ActionGroup/CheckoutActionGroup.xml

@@ -222,7 +222,7 @@
     <!-- Check product in checkout cart items -->
     <actionGroup name="CheckProductInCheckoutCartItemsActionGroup">
         <annotations>
-            <description>Validates the the provided Product appears in the Storefront Checkout 'Order Summary' section.</description>
+            <description>Validates the provided Product appears in the Storefront Checkout 'Order Summary' section.</description>
         </annotations>
         <arguments>
             <argument name="productVar"/>

app/code/Magento/Checkout/Test/Unit/Model/Cart/RequestQuantityProcessorTest.php

@@ -48,6 +48,9 @@ public function testProcess($cartData, $expected)
         $this->assertEquals($this->requestProcessor->process($cartData), $expected);
     }
 
+    /**
+     * @return array
+     */
     public function cartDataProvider()
     {
         return [

app/code/Magento/Config/Test/Mftf/ActionGroup/AdminConfigCreateNewAccountActionGroup.xml

@@ -10,7 +10,7 @@
               xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
     <actionGroup name="SetGroupForValidVATIdIntraUnionActionGroup">
         <annotations>
-            <description>Goes to the 'Configuration' page for 'Customer Configuration'. Sets the 'Group For Valid VAT ID Intra Union' option. Clicks on the Save button. Validates the the Save message is present.</description>
+            <description>Goes to the 'Configuration' page for 'Customer Configuration'. Sets the 'Group For Valid VAT ID Intra Union' option. Clicks on the Save button. Validates the Save message is present.</description>
         </annotations>
         <arguments>
             <argument name="value" type="string"/>

app/code/Magento/Deploy/Console/DeployStaticOptions.php

@@ -78,6 +78,11 @@ class DeployStaticOptions
      */
     const NO_JAVASCRIPT = 'no-javascript';
 
+    /**
+     * Key for js-bundle option
+     */
+    const NO_JS_BUNDLE = 'no-js-bundle';
+
     /**
      * Key for css option
      */
@@ -122,9 +127,6 @@ class DeployStaticOptions
      */
     const NO_LESS = 'no-less';
 
-    /**
-     * Default jobs amount
-     */
     const DEFAULT_JOBS_AMOUNT = 0;
 
     /**
@@ -275,6 +277,12 @@ private function getSkipOptions()
                 InputOption::VALUE_NONE,
                 'Do not deploy JavaScript files.'
             ),
+            new InputOption(
+                self::NO_JS_BUNDLE,
+                null,
+                InputOption::VALUE_NONE,
+                'Do not deploy JavaScript bundle files.'
+            ),
             new InputOption(
                 self::NO_CSS,
                 null,