Skip to content

Conversation

@oleksii-lisovyi
Copy link

Description (*)

This PR fixes issue with displaying available allowed countries while editing order billing/shipping address in Admin panel in case of multi-store website Magneto configuration.
Currently configuration value is taken from Default scope level, not from a specific website.

Fixed Issues (if relevant)

  1. Back-End issue for multi-store website: when editing Order shipping/billing address - allowed countries are selected from wrong Store View  #12560: Back-End issue for multi-store website: when editing Order shipping/billing address - allowed countries are selected from wrong Store View

Manual testing scenarios (*)

You can find steps to reproduce in the linked issue.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @oleksii-lisovyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@oleksii-lisovyi oleksii-lisovyi force-pushed the fix-availalbe-allowed-countries-for-order-address-in-admin-panel branch from 1f28119 to d617c3c Compare August 28, 2019 15:52
@josefbehr josefbehr self-assigned this Aug 29, 2019
@josefbehr
Copy link
Contributor

@oleksii-lisovyi Thank you for this PR. Can you have a look at the one failing test, please?

…r address in Admin panel

- fixed unit test
@oleksii-lisovyi
Copy link
Author

@josefbehr, related commit has been added.

@josefbehr josefbehr added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-5738 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @oleksii-lisovyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants